mm/rmap: Refactor try_to_unmap_one
Status from this message: [merged mm-stable] mm-rmap-add-anon-folio-unmap-dispatcher.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 2 repliesApplied 5/5
- v35 patches 7 repliesSuperseded
- v25 patches 13 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 5 patches | 10 replies | Superseded |
Changes in v4 from the cover letter
- Tighten comment around TTU_HWPOISON
- try_to_unmap_hugetlb_one -> try_to_unmap_poisoned_hugetlb_one
- VM_WARN_ON -> VM_WARN_ON_ONCE
Patches in v4 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mm/rmap: convert page -> folio for hwpoison checksmm/ | +6 | 1 reply | Applied |
| 2/5 | mm/rmap: Add try_to_unmap_poisoned_hugetlb_oneinclude/ mm/ | +98 | 0 replies | Applied |
| 3/5 | mm/rmap: refactor some code around lazyfree folio unmappingmm/ | +48 | 0 replies | Applied |
| 4/5 | mm/rmap: refactor anon folio unmap in try_to_unmap_onemm/ | +68 | 0 replies | Applied |
| 5/5 | mm/rmap: add anon folio unmap dispatchermm/ | +23 | 0 replies | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Lorenzo Stoakes (ARM) | David Hildenbrand (Arm) | Anshuman Khandual |
|---|---|---|---|
| 1/5 | R-b | A-b | R-b |
| 2/5 | R-b | A-b | |
| 3/5 | A-b | ||
| 4/5 | A-b | ||
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/5] mm/rmap: Refactor try_to_unmap_one
In preparation for batching anonymous large folio unmapping to optimize it, refactor try_to_unmap_one. This series refactors hugetlb, anon-lazyfree and anon-swapbacked logic into their own functions, significantly reducing the length of the huge try_to_unmap_one.
---
Based on mm-unstable (d8c677ce1220b0db119ada6c6f9762c07c4d8aca).
Split out from
https://lore.kernel.org/all/[email protected]/
mm-selftests pass on arm64, built on arm64 and x86.
v3->v4:
- Tighten comment around TTU_HWPOISON
- try_to_unmap_hugetlb_one -> try_to_unmap_poisoned_hugetlb_one
- VM_WARN_ON -> VM_WARN_ON_ONCE
v2->v3:
- Patch 2: fix comment to say that TTU_HWPOISON can be true for small folios only in try_to_unmap_one, since hugetlb bits are now refactored away
- Patch 5: Directly do if (WARN_ON_ONCE())
- Rebase on latest mm-unstable to resolve conflicts with 30c83145c5b3 ("mm: rename uffd-wp PTE accessors to uffd")
v1->v2:
- constify ttu flags in try_to_unmap_hugetlb_one, move const variables up
- Assert address passed to try_to_unmap_hugetlb_one equals pvmw.address
- Patch 3: code and comment polishing, do the stat update in the function
- Remove unnecessary inline hints, remove set_swp_pte_at, instead have swp_pte_prepare + set_ptes. Rename subpage -> page. constify anon_exclusive.
- Do pte restoration in caller
Dev Jain (5):
mm/rmap: convert page -> folio for hwpoison checks mm/rmap: Add try_to_unmap_poisoned_hugetlb_one mm/rmap: refactor some code around lazyfree folio unmapping mm/rmap: refactor anon folio unmap in try_to_unmap_one mm/rmap: add anon folio unmap dispatcher
include/linux/hugetlb.h | 1 + mm/rmap.c | 415 ++++++++++++++++++++++------------------ 2 files changed, 232 insertions(+), 184 deletions(-)
Signature · 1 line
2.43.0