Skip to content

RFC mm/damon: update probe hits for runtime parameter commits

SJ Park damon linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mm/damon/core: remove comment and test for nr_to_bp() divide-by-zeromm/damon/core.c mm/damon/tests/core-kunit.h+1 -300 replies
2/7mm/damon/core: s/damon_max_nr_accesses()/damon_nr_samples_per_aggr()/include/linux/damon.h mm/damon/core.c mm/damon/lru_sort.c +1 more+10 -81 reply
3/7mm/damon/core: s/accesses_bp_to_nr_accesses/sample_bp_to_count/mm/damon/core.c+5 -50 replies
4/7mm/damon/core: s/nr_accesses_to_accesses_bp/sample_count_to_bp/mm/damon/core.c+5 -60 replies
5/7mm/damon/core: s/nr_accesses_for_new_attrs/nr_samples_for_new_attrs/mm/damon/core.c+4 -51 reply
6/7mm/damon/core: update probe hits for new parameter commitmm/damon/core.c mm/damon/tests/core-kunit.h+35 -61 reply
7/7mm/damon/core: handle unreset probe_hits in probe_hits_mvsum()mm/damon/core.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH v1.3 0/7] mm/damon: update probe hits for runtime parameter commits

DAMON users can update DAMON parameters such as sampling and aggregation intervals at runtime. For such changes, monitoring results that depend on the intervals should be properly updated for better accuracy. For example, the access frequency counter (nr_accesses) is updated. The data attribute monitoring counter (probe_hits) is not being updated, though. Do the updates for new parameters.

Patches Sequence
================

Patch 1 removes obsolete comments and test code for a function that this series will touch. Patches 2-5 rename functions that are being used for nr_accesses update, to be able to be used for probe_hits without confusion. Patch 6 does the probe_hits update. Patch 7 update damon_probe_hits_mvsum() to cover a corner case from the update for better accuracy.

Changelog
=========

Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/[email protected]
- Fix rebase failure-caused kunit break in patch 1.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Remove obsolete divide-by-zero test with comments as a separate patch.
- Remove obsolete comment removal part in a rename commit message.
- Rename name-changed function parameters.
Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Remove obsolete comment and code on the test.

SJ Park (7):
mm/damon/core: remove comment and test for nr_to_bp() divide-by-zero mm/damon/core: s/damon_max_nr_accesses()/damon_nr_samples_per_aggr()/ mm/damon/core: s/accesses_bp_to_nr_accesses/sample_bp_to_count/ mm/damon/core: s/nr_accesses_to_accesses_bp/sample_count_to_bp/ mm/damon/core: s/nr_accesses_for_new_attrs/nr_samples_for_new_attrs/ mm/damon/core: update probe hits for new parameter commit mm/damon/core: handle unreset probe_hits in probe_hits_mvsum()

 include/linux/damon.h       | 10 +++---
 mm/damon/core.c             | 65 +++++++++++++++++++++++--------------
 mm/damon/lru_sort.c         |  2 +-
 mm/damon/ops-common.c       |  2 +-
 mm/damon/tests/core-kunit.h | 36 ++++++--------------
 5 files changed, 59 insertions(+), 56 deletions(-)

base-commit: 82154b14568e9b7abebe2fc9240eafd031e01b30

Signature · 1 line
2.47.3