RFC Refactor the workqueue allocations
Get series with b4
b4 am [email protected] change-id 20260709-tejun1-c2aaf36f54a4Versions newest first
- v1 RFC Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | workqueue: introduce alloc_pwq()kernel/ | +42 | 0 replies | |
| 2/3 | workqueue: allocate percpu pwqs through alloc_pwq()kernel/ | +1 | 0 replies | |
| 3/3 | workqueue: factor out alloc_and_link_percpu_pwqs()kernel/ | +20 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 0/3] Refactor the workqueue allocations
POC for Tejun's idea to unify the per-cpu and unbound workqueues, as suggested in http://lkml.kernel.org/r/[email protected]
This series only unifies the allocation part (alloc_pwq()). It makes alloc_pwq() a single allocator that returns a pwq backed by either a static per-cpu pool (get_percpu_pool) or an unbound pool (get_unbound_pool), reusing the existing static per-cpu pools. The install/link path is unchanged and all patches are behavior-neutral. This sets things up to unify the install side later.
Is this the right direction?
Questions to follow up:
1) wqattrs is an unbound concept and apply_workqueue_attrs_locked() rejects non-unbound wqs. Should we leverage wqattrs in per-cpu workqueues as well, so the unification can happen later (apply_workqueue_attrs_locked())?
2) If percpu becomes a WQ_AFFN_CPU affinity setting, how should max_active be treated? WQ_AFFN_CPU is unbound today, so it would inherit per-node accounting (wq_node_nr_active) and lose percpu's per-cpu max_active (pwq->nr_active).
3) What end state are you aiming for? Keep WQ_PERCPU as a thin flag over unified internals (single install path, per-cpu accounting special-cased) with WQ_UNBOUND staying for now -- or something more radical (the flags gone entirely, percpu purely an affinity value)?
Tests:
1) I've tested this on x86 and arm64, with regular tests
2) I've hacked up a workqueue test suite, which has a bunch of tests, and this is what I am using to test these changes:
https://github.com/leitao/wqtest
Thanks,
-breno
---
Breno Leitao (3):
workqueue: introduce alloc_pwq()
workqueue: allocate percpu pwqs through alloc_pwq()
workqueue: factor out alloc_and_link_percpu_pwqs()
kernel/workqueue.c | 96 ++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 60 insertions(+), 36 deletions(-)
---
base-commit: b9810cd75b9fb56a3425d391cba3f608502bd474
change-id: 20260709-tejun1-c2aaf36f54a4
Best regards,
Signature · 1 line
Breno Leitao <[email protected]>