Skip to content

ipvs: csum validations and data offsets

Julian Anastasov lvs-devel netfilter-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v22 patches 1 replySuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

* patch 2: add __maybe_unused to coff and outer_proto to silence the compiler warnings when IPVS debugging is not enabled, reported by the kernel test robot <[email protected]>:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
* add patch 3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ipvs: fix the checksum validationsinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_core.c net/netfilter/ipvs/ip_vs_proto_sctp.c +2 more+77 -860 replies
2/3ipvs: fix places with wrong packet offsetsinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_app.c net/netfilter/ipvs/ip_vs_core.c +4 more+97 -930 replies
3/3ipvs: do not mangle ICMP replies for non-first fragmentsinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_core.c net/netfilter/ipvs/ip_vs_xmit.c+48 -520 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH nf v3 0/3] ipvs: csum validations and data offsets

Hello,

This patchset contains fixes for the checksum
validations for ICMPv6 and switches TCP, UDP and ICMP to use nf_checksum for LOCAL_IN.

	It also corrects offsets to be based on skb->data and to

respect the network offset.

Finally, it prevents to read/write ICMP payload for
non-first embedded fragments wrongly assuming the TCP/UDP/SCTP ports are present there.

Changes:

v2->v3:
* patch 2: add __maybe_unused to coff and outer_proto to silence the compiler warnings when IPVS debugging is not enabled, reported by the kernel test robot <[email protected]>:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
* add patch 3

v1->v2:
* patch 1: switch to using nf_checksum, validate only at LOCAL_IN and for MASQ
* add patch 2

Julian Anastasov (3):
ipvs: fix the checksum validations
ipvs: fix places with wrong packet offsets
ipvs: do not mangle ICMP replies for non-first fragments

 include/net/ip_vs.h                   |  48 +++++--
 net/netfilter/ipvs/ip_vs_app.c        |   4 +-
 net/netfilter/ipvs/ip_vs_core.c       | 180 +++++++++++++-------------
 net/netfilter/ipvs/ip_vs_proto_sctp.c |  19 +--
 net/netfilter/ipvs/ip_vs_proto_tcp.c  |  48 ++-----
 net/netfilter/ipvs/ip_vs_proto_udp.c  |  54 ++------
 net/netfilter/ipvs/ip_vs_xmit.c       |  42 ++++--
 7 files changed, 193 insertions(+), 202 deletions(-)
Signature · 1 line
2.55.0