Skip to content

oe/path: three fixes plus unit coverage

Trevor Woerner yocto-patches 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4oe/path: fix bare `false` NameError in __realpath's isdir guardsrc/wic/oe/path.py+1 -10 replies
2/4oe/path: don't glob-expand the destination in symlink(force=True)src/wic/oe/path.py+12 -10 replies
3/4oe/path: canonicalize('') should return '' rather than the cwdsrc/wic/oe/path.py+5 -10 replies
4/4tests/unit/test_oe_path: cover oe/path's own path logictests/unit/test_oe_path.py+298 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [wic][PATCH 0/4] oe/path: three fixes plus unit coverage

This series continues the standalone unit-test work, this time over oe/path.py. It follows the same shape the suite settled on: each source fix is its own standalone commit, and the green test module lands last, so the suite passes at every commit.

Three fixes come first, each independent of the others:

- __realpath's isdir guard assigns a bare false, which is not a Python name; when os.path.isdir() raises, the handler meant to absorb the error raises NameError instead. Use the builtin False.
- symlink(force=True) cleared the destination through remove(), which globs its argument; a destination containing glob metacharacters could fail to match itself or match unrelated files. Remove the literal destination instead.
- canonicalize('') and canonicalize(None) returned the current working directory, because os.path.realpath('') does; a stray separator injected a spurious cwd entry too. Skip empty tokens.

The final commit adds tests/unit/test_oe_path.py, covering oe/path's own logic (join, is_path_parent, symlink, make_relative_symlink, canonicalize, which_wild, realpath) and locking in the three fixes. Backing any fix out turns the matching test red. The suite is green and ruff-clean, and the series passes oe-core's wic oe-selftest with no regressions.

Trevor Woerner (4):
oe/path: fix bare false NameError in __realpath's isdir guard oe/path: don't glob-expand the destination in symlink(force=True) oe/path: canonicalize('') should return '' rather than the cwd tests/unit/test_oe_path: cover oe/path's own path logic

 src/wic/oe/path.py         |  21 ++-
 tests/unit/test_oe_path.py | 298 +++++++++++++++++++++++++++++++++++++
 2 files changed, 316 insertions(+), 3 deletions(-)
 create mode 100644 tests/unit/test_oe_path.py
Signature · 1 line
2.50.0.173.g8b6f19ccfc3a