Skip to content

ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handling

[email protected] linux-arm-kernel linux-sound lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Split out a separate patch to preserve devm_request_irq() error codes.
- Adjust line wrapping.
- Add the Reviewed-by tag.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handlingsound/soc/xilinx/xlnx_i2s.c+7 -110 replies
2/3ASoC: xilinx: xlnx_spdif: Preserve devm_request_irq() error codessound/soc/xilinx/xlnx_spdif.c+2 -40 replies
3/3ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error handlingsound/soc/xilinx/xlnx_spdif.c+9 -160 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichal Simek
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handling

From: bui duc phuc <[email protected]>

Hi all,

This series cleans up error handling in the Xilinx ASoC drivers. It replaces dev_err() followed by return with dev_err_probe() where appropriate in probe paths, allowing deferred probe to be handled correctly while simplifying the code.
It also removes redundant dev_err() calls after helper functions that already report failures, avoiding duplicate error messages.

Changes in v2:
- Split out a separate patch to preserve devm_request_irq() error codes.
- Adjust line wrapping.
- Add the Reviewed-by tag.

Best regards,
Phuc

bui duc phuc (3):
ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error
handling
ASoC: xilinx: xlnx_spdif: Preserve devm_request_irq() error codes
ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error
handling

 sound/soc/xilinx/xlnx_i2s.c   | 18 +++++++-----------
 sound/soc/xilinx/xlnx_spdif.c | 31 +++++++++++--------------------
 2 files changed, 18 insertions(+), 31 deletions(-)
Signature · 1 line
2.43.0