perf/x86: Miscellaneous PMU bug fixes and optimizations
Status from this message: The following commit has been merged into the perf/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 13 repliesApplied
- v27 patches 3 repliesSuperseded
- v17 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- Patch 6/8: Fix the typo in comments (Thomas).
- Patch 8/8: New patch which prevents drain_pebs() reentry.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | perf/x86: Unregister PMI handler on PMU init failurearch/ | +3 | 1 reply | |
| 2/8 | perf/x86: Free hybrid state on PMU init failurearch/ | +12 | 0 replies | |
| 3/8 | perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU castsarch/ arch/ arch/ | +11 | 1 reply | |
| 4/8 | perf/x86/intel: Unwind cpuc state if PEBS buffer setup failsarch/ | +9 | 0 replies | |
| 5/8 | perf/x86: Remove stale fixed counter helper and fix hybrid PMU accessarch/ arch/ arch/ | +4 | 0 replies | |
| 6/8 | perf/x86/intel: Fix intel_cap handling on hybrid PMUsarch/ | +30 | 2 replies | |
| 7/8 | perf/x86: Optimize ACR handling in match_prev_assignment()arch/ arch/ | +13 | 0 replies | |
| 8/8 | perf/x86/intel: Prevent drain_pebs() reentryarch/ arch/ | +32 | 7 replies |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Thomas Falcon | Zide Chen |
|---|---|---|
| Series | R-b | |
| 1/8 | R-b | |
| 2/8 | R-b | |
| 3/8 | R-b | |
| 4/8 | R-b | |
| 5/8 | R-b | |
| 6/8 | R-b | |
| 7/8 | R-b | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Patch v3 0/8] perf/x86: Miscellaneous PMU bug fixes and optimizations
Changes since v2:
- Patch 6/8: Fix the typo in comments (Thomas).
- Patch 8/8: New patch which prevents drain_pebs() reentry.
Changes since v1:
- Patch 3/7: Ensure cpuc->pmu is not the static pmu before calling hybrid_pmu(cpuc->pmu) in intel_pmu_cpu_dead() (Sashiko).
This series fixes recently found x86 core PMU bugs. Most of bugs are found by Sashiko in reviewing the "Support SIMD/eGPRs/SSP registers sampling for perf" patch-set, e.g.,
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
The patch 7/8 optimizes ACR handling in match_prev_assignment() and mitigate the performance overhead.
The patch 8/8 enhances intel_pmu_drain_pebs_buffer() to prevent drain_pebs() reentry.
Tests:
Below test cases are run on Diamonds and Novalake. No issues are found.
- Perf stat test
$ perf test 119 - Perf record tests $ perf test 155 - Perf record LBR tests $ perf test 156
History:
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
Dapeng Mi (8):
perf/x86: Unregister PMI handler on PMU init failure perf/x86: Free hybrid state on PMU init failure
perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU casts perf/x86/intel: Unwind cpuc state if PEBS buffer setup fails perf/x86: Remove stale fixed counter helper and fix hybrid PMU access perf/x86/intel: Fix intel_cap handling on hybrid PMUs perf/x86: Optimize ACR handling in match_prev_assignment() perf/x86/intel: Prevent drain_pebs() reentry
arch/x86/events/core.c | 45 ++++++++++++---- arch/x86/events/intel/core.c | 101 ++++++++++++++++++++++++++--------- arch/x86/events/intel/ds.c | 7 --- arch/x86/events/perf_event.h | 12 ++--- 4 files changed, 113 insertions(+), 52 deletions(-)
base-commit: edda9051e267b7390c7ce24b1b71434414ad156e
Signature · 1 line
2.34.1