Skip to content

perf/x86: Miscellaneous PMU bug fixes and optimizations

Dapeng Mi linux-perf-users lkml sashiko-reviews 3 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 13 repliesApplied
  2. v27 patches 3 repliesSuperseded
  3. v17 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Patch 6/8: Fix the typo in comments (Thomas).
- Patch 8/8: New patch which prevents drain_pebs() reentry.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8perf/x86: Unregister PMI handler on PMU init failurearch/x86/events/core.c+3 -11 reply
2/8perf/x86: Free hybrid state on PMU init failurearch/x86/events/core.c+12 -30 replies
3/8perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU castsarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h+11 -21 reply
4/8perf/x86/intel: Unwind cpuc state if PEBS buffer setup failsarch/x86/events/intel/core.c+9 -20 replies
5/8perf/x86: Remove stale fixed counter helper and fix hybrid PMU accessarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h+4 -170 replies
6/8perf/x86/intel: Fix intel_cap handling on hybrid PMUsarch/x86/events/intel/core.c+30 -112 replies
7/8perf/x86: Optimize ACR handling in match_prev_assignment()arch/x86/events/core.c arch/x86/events/perf_event.h+13 -20 replies
8/8perf/x86/intel: Prevent drain_pebs() reentryarch/x86/events/intel/core.c arch/x86/events/intel/ds.c+32 -157 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThomas FalconZide Chen
SeriesR-b
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Patch v3 0/8] perf/x86: Miscellaneous PMU bug fixes and optimizations

Changes since v2:
- Patch 6/8: Fix the typo in comments (Thomas).
- Patch 8/8: New patch which prevents drain_pebs() reentry.

Changes since v1:
- Patch 3/7: Ensure cpuc->pmu is not the static pmu before calling hybrid_pmu(cpuc->pmu) in intel_pmu_cpu_dead() (Sashiko).

This series fixes recently found x86 core PMU bugs. Most of bugs are found by Sashiko in reviewing the "Support SIMD/eGPRs/SSP registers sampling for perf" patch-set, e.g.,
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

The patch 7/8 optimizes ACR handling in match_prev_assignment() and mitigate the performance overhead.

The patch 8/8 enhances intel_pmu_drain_pebs_buffer() to prevent drain_pebs() reentry.

Tests:
Below test cases are run on Diamonds and Novalake. No issues are found.
- Perf stat test

  $ perf test 119
- Perf record tests 
  $ perf test 155
- Perf record LBR tests
  $ perf test 156

History:
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Dapeng Mi (8):
perf/x86: Unregister PMI handler on PMU init failure perf/x86: Free hybrid state on PMU init failure
perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU casts perf/x86/intel: Unwind cpuc state if PEBS buffer setup fails perf/x86: Remove stale fixed counter helper and fix hybrid PMU access perf/x86/intel: Fix intel_cap handling on hybrid PMUs perf/x86: Optimize ACR handling in match_prev_assignment() perf/x86/intel: Prevent drain_pebs() reentry

 arch/x86/events/core.c       |  45 ++++++++++++----
 arch/x86/events/intel/core.c | 101 ++++++++++++++++++++++++++---------
 arch/x86/events/intel/ds.c   |   7 ---
 arch/x86/events/perf_event.h |  12 ++---
 4 files changed, 113 insertions(+), 52 deletions(-)

base-commit: edda9051e267b7390c7ce24b1b71434414ad156e

Signature · 1 line
2.34.1