SWN: Decouple witness registrations and tcons
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest18 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | Revert "smb: client: resolve SWN tcon from live registrations"fs/ fs/ | +54 | 0 replies | |
| 2/18 | smb:client: Adjust witness notification requestfs/ | +3 | 0 replies | |
| 3/18 | smb:client: Rename variable to match the rest of the codefs/ | +25 | 0 replies | |
| 4/18 | smb:client: Split idr remove and release functionsfs/ | +10 | 0 replies | |
| 5/18 | smb:client: Add a specific task to refresh witness registrationsfs/ fs/ fs/ | +79 | 0 replies | |
| 6/18 | smb:client: Store the tcon dstaddr in the witness registrationfs/ | +56 | 0 replies | |
| 7/18 | smb:client: Fix printf format stringfs/ | +1 | 0 replies | |
| 8/18 | smb:client: Save memory allocationsfs/ | +68 | 0 replies | |
| 9/18 | smb:client: Use the correct return codefs/ | +2 | 0 replies | |
| 10/18 | smb:client: Improve tcon matching logicfs/ | +72 | 0 replies | |
| 11/18 | smb:client: Pass the tcon to cifs_swn_send_register_messagefs/ | +7 | 0 replies | |
| 12/18 | smb:client: Pass the tcon to notification handlersfs/ | +10 | 0 replies | |
| 13/18 | smb:client: Introduce swn_notification structfs/ | +99 | 0 replies | |
| 14/18 | smb:client: Cache auth infofs/ | +138 | 0 replies | |
| 15/18 | smb:client: Do not store the tcon reference, find a matching onefs/ fs/ | +166 | 0 replies | |
| 16/18 | smb:client: Simplify registration creationfs/ | +106 | 0 replies | |
| 17/18 | smb:client: Improve registration network and share names handlingfs/ | +61 | 0 replies | |
| 18/18 | smb:client: Avoid witness re-register if the address did not changefs/ | +33 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/18] SWN: Decouple witness registrations and tcons
This patches removes the cached tcon pointers from the witness registrations.
First patch in the serie reverts the current approach based on snapshots that fixes a race while processing a received notification. This patchset implements a different approach based on reference counting and fixes other races that could occur with concurrent register/unregister/notification processing.
The witness registration stores now all required information to issue register/unregister DCERPC calls (like auth info and target address), and when a notification is received it applies it to all matching witness-enabled tcons.
Each witness registration has its own task to enforce the registration in case the userspace daemon is started after mounting the share, instead of overload the echo task for this purpose.
Samuel Cabrero (18):
Revert "smb: client: resolve SWN tcon from live registrations" smb:client: Adjust witness notification request smb:client: Rename variable to match the rest of the code smb:client: Split idr remove and release functions smb:client: Add a specific task to refresh witness registrations smb:client: Store the tcon dstaddr in the witness registration smb:client: Fix printf format string
smb:client: Save memory allocations
smb:client: Use the correct return code
smb:client: Improve tcon matching logic
smb:client: Pass the tcon to cifs_swn_send_register_message smb:client: Pass the tcon to notification handlers smb:client: Introduce swn_notification struct smb:client: Cache auth info
smb:client: Do not store the tcon reference, find a matching one smb:client: Simplify registration creation
smb:client: Improve registration network and share names handling smb:client: Avoid witness re-register if the address did not change
fs/smb/client/cifs_swn.c | 1179 ++++++++++++++++++++++---------------- fs/smb/client/cifs_swn.h | 3 - fs/smb/client/connect.c | 3 - fs/smb/client/trace.h | 4 +- 4 files changed, 682 insertions(+), 507 deletions(-)
Signature · 1 line
2.54.0