Skip to content

Rework FIXMEs and fprintfs in hcd-xhci.c

Thomas Huth qemu-devel qemu-trivial 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesIn review
  2. v33 patches 6 repliesSuperseded
  3. v21 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch2 repliesSuperseded

Changes in v4 from the cover letter

- Remove the DPRINTF in the second patch
- Add the missing \n in the third patch

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/usb/hcd-xhci: Turn guest-triggerable abort() into qemu_log_mask()hw/usb/hcd-xhci.c+4 -20 replies
2/3hw/usb/hcd-xhci: Remove the FIXME macrohw/usb/hcd-xhci.c+1 -50 replies
3/3hw/usb/hcd-xhci: Use qemu_log_mask() instead of fprintf() statementhw/usb/hcd-xhci.c+2 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-Daudé
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] Rework FIXMEs and fprintfs in hcd-xhci.c

Replace the local FIXME macro and fprintf statement with qemu_log_mask() and g_assert_not_reached().

v4:
- Remove the DPRINTF in the second patch
- Add the missing \n in the third patch

Thomas Huth (3):
hw/usb/hcd-xhci: Turn guest-triggerable abort() into qemu_log_mask() hw/usb/hcd-xhci: Remove the FIXME macro
hw/usb/hcd-xhci: Use qemu_log_mask() instead of fprintf() statement

 hw/usb/hcd-xhci.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
Signature · 1 line
2.55.0