Skip to content

iotests: fix three spurious local failures

Denis V. Lunev qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesApplied
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- patch 1: drop the now-unused 'Pool' import (Kevin)
- patch 2: rename _notrun_on_no_fuse to _notrun_on_fuse_error (Kevin)
- patch 3: replace the dropped assertion with a check that bitmap0's content on the destination has not reached its final value right after RESUME, throttling migration bandwidth

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3iotests: run the test pool with the 'fork' start methodtests/qemu-iotests/testrunner.py+2 -21 reply
2/3iotests: skip FUSE tests when FUSE is not usabletests/qemu-iotests/common.rc tests/qemu-iotests/tests/file-io-error tests/qemu-iotests/tests/fuse-allow-other +1 more+23 -61 reply
3/3iotests/migrate-bitmaps-postcopy-test: replace the timing assertion with a content checktests/qemu-iotests/tests/migrate-bitmaps-postcopy-test+14 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyDaniel P. Berrangé
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] iotests: fix three spurious local failures

Three independent fixes found while chasing a clean './check -qcow2' run on a Python 3.14 host. Unrelated to each other, sent as one series since they came out of the same session.

v2:
- patch 1: drop the now-unused 'Pool' import (Kevin)
- patch 2: rename _notrun_on_no_fuse to _notrun_on_fuse_error (Kevin)
- patch 3: replace the dropped assertion with a check that bitmap0's content on the destination has not reached its final value right after RESUME, throttling migration bandwidth

CC Kevin Wolf <[email protected]>
CC Hanna Reitz <[email protected]>
CC Vladimir Sementsov-Ogievskiy <[email protected]>

Denis V. Lunev (3):
iotests: run the test pool with the 'fork' start method
iotests: skip FUSE tests when FUSE is not usable iotests/migrate-bitmaps-postcopy-test: replace the timing assertion
with a content check

 tests/qemu-iotests/common.rc                      | 14 ++++++++++++++
 tests/qemu-iotests/testrunner.py                  |  4 ++--
 tests/qemu-iotests/tests/file-io-error            |  4 +---
 tests/qemu-iotests/tests/fuse-allow-other         |  2 ++
 tests/qemu-iotests/tests/fuse-mmap-shared         |  9 ++++++---
 .../tests/migrate-bitmaps-postcopy-test           | 15 ++++++++++++++-
 6 files changed, 39 insertions(+), 9 deletions(-)
Signature · 1 line
2.53.0