Skip to content

wifi: iwlwifi: mvm: bound BA-window station ID

Michael Bommarito linux-wireless lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wifi: iwlwifi: mvm: check BA-window station ID before lookupdrivers/net/wireless/intel/iwlwifi/mvm/rx.c+4 -00 replies
2/2wifi: iwlwifi: mvm: add KUnit coverage for BA-window station ID boundsdrivers/net/wireless/intel/iwlwifi/mvm/tests/Makefile drivers/net/wireless/intel/iwlwifi/mvm/tests/window-status.c+78 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] wifi: iwlwifi: mvm: bound BA-window station ID

iwl_mvm_window_status_notif() extracts a 5-bit station ID from the firmware's BA-window status notification (values up to 31) and indexes mvm->fw_id_to_mac_id[] with it without first checking it against the firmware's station capacity. A firmware/backend notification carrying an out-of-range ID reads past the station map.

Patch 1 validates the station ID against mvm->fw->ucode_capa.num_stations before the lookup, matching the existing MVM station-lookup helpers. Patch 2 adds KUnit coverage: the malformed out-of-range ID and a valid-ID/ null-station control that must still pass.

Reproduced with the KUnit test under UBSAN bounds: the malformed case reports an array-index-out-of-bounds splat on stock and passes after the fix; the valid-ID control passes on both.

Michael Bommarito (2):
wifi: iwlwifi: mvm: check BA-window station ID before lookup
wifi: iwlwifi: mvm: add KUnit coverage for BA-window station ID bounds

 drivers/net/wireless/intel/iwlwifi/mvm/rx.c   |  4 +
 .../wireless/intel/iwlwifi/mvm/tests/Makefile |  2 +-
 .../intel/iwlwifi/mvm/tests/window-status.c   | 77 +++++++++++++++++++
 3 files changed, 82 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/tests/window-status.c

--
2.53.0