Skip to content

Minor fixes for xdrgen

Chuck Lever linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xdrgen: Emit a blank line ahead of enum declarationsfs/lockd/nlm3xdr_gen.c fs/lockd/nlm3xdr_gen.h fs/lockd/nlm4xdr_gen.c +7 more+13 -90 replies
2/5xdrgen: Share void RPC procedure handlers across programsfs/lockd/nlm3xdr_gen.c fs/lockd/nlm3xdr_gen.h fs/lockd/nlm4xdr_gen.c +7 more+80 -1080 replies
3/5xdrgen: Do not declare union XDR functions in the definitions headertools/net/sunrpc/xdrgen/templates/C/union/definition/close.j2+0 -60 replies
4/5xdrgen: Add XDR width macros for short integer typesinclude/linux/sunrpc/xdrgen/_defs.h+2 -00 replies
5/5xdrgen: Fix opaque and string encoders for unbounded memberstools/net/sunrpc/xdrgen/templates/C/pointer/encoder/string.j2 tools/net/sunrpc/xdrgen/templates/C/pointer/encoder/variable_length_opaque.j2 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/string.j2 +1 more+8 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Minor fixes for xdrgen

While working on server-side xdrgen conversion for NFSv2 and NFSv3, I found several unrelated minor issues with the xdrgen tool. They are collected here in this series.

Chuck Lever (5):
xdrgen: Emit a blank line ahead of enum declarations
xdrgen: Share void RPC procedure handlers across programs
xdrgen: Do not declare union XDR functions in the definitions header
xdrgen: Add XDR width macros for short integer types
xdrgen: Fix opaque and string encoders for unbounded members

 fs/lockd/nlm3xdr_gen.c                        | 30 +-------------
 fs/lockd/nlm3xdr_gen.h                        |  4 +-
 fs/lockd/nlm4xdr_gen.c                        | 30 +-------------
 fs/lockd/nlm4xdr_gen.h                        |  4 +-
 fs/lockd/svc4proc.c                           | 40 +++++++++----------
 fs/lockd/svcproc.c                            | 40 +++++++++----------
 fs/nfsd/nfs4xdr_gen.c                         |  2 +-
 fs/nfsd/nfs4xdr_gen.h                         |  5 ++-
 include/linux/sunrpc/xdrgen/_builtins.h       | 32 +++++++++++++++
 include/linux/sunrpc/xdrgen/_defs.h           |  2 +
 include/linux/sunrpc/xdrgen/nfs4_1.h          |  2 +-
 include/linux/sunrpc/xdrgen/nlm3.h            |  2 +-
 include/linux/sunrpc/xdrgen/nlm4.h            |  2 +-
 tools/net/sunrpc/xdrgen/generators/program.py |  8 ++++
 .../templates/C/enum/declaration/enum.j2      |  1 +
 .../templates/C/pointer/encoder/string.j2     |  2 +
 .../pointer/encoder/variable_length_opaque.j2 |  2 +
 .../templates/C/program/decoder/argument.j2   |  4 --
 .../templates/C/program/encoder/result.j2     |  4 --
 .../templates/C/struct/encoder/string.j2      |  2 +
 .../struct/encoder/variable_length_opaque.j2  |  2 +
 .../templates/C/union/definition/close.j2     |  6 ---
 22 files changed, 103 insertions(+), 123 deletions(-)
Signature · 1 line
2.54.0