Skip to content

Start reorganizing fs/nfsd/nfsd.h

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9NFSD: Make "stats.h" self-containedfs/nfsd/stats.h+3 -00 replies
2/9NFSD: Explicitly include "stats.h"fs/nfsd/nfs4state.c fs/nfsd/nfscache.c fs/nfsd/nfsctl.c +4 more+6 -10 replies
3/9NFSD: include "netns.h"fs/nfsd/nfscache.c fs/nfsd/nfsctl.c fs/nfsd/nfsd.h +6 more+13 -40 replies
4/9NFSD: Remove '#include "nfsd.h"' from fs/nfsd/cache.hfs/nfsd/cache.h+2 -10 replies
5/9NFSD: Move the export.h include from nfsd.h to auth.cfs/nfsd/auth.c fs/nfsd/nfsd.h+1 -20 replies
6/9NFSD: Move struct readdir_cdfs/nfsd/nfsd.h fs/nfsd/vfs.h fs/nfsd/xdr.h +2 more+7 -60 replies
7/9NFSD: Relocate nfsd_user_namespace()fs/nfsd/auth.c fs/nfsd/auth.h fs/nfsd/nfs4idmap.c +2 more+26 -60 replies
8/9NFSD: Relocate nfsd4_set_netaddr()fs/nfsd/nfs4proc.c fs/nfsd/nfsd.h+31 -330 replies
9/9NFSD: Relocate NFSv4 "supported attributes" to new headerfs/nfsd/attr4.h fs/nfsd/nfs4proc.c fs/nfsd/nfs4xdr.c +1 more+164 -1500 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJeff Layton
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Start reorganizing fs/nfsd/nfsd.h

fs/nfsd/nfsd.h has become a kitchen sink of unrelated declarations and definitions, including a broad swathe of headers and other detritus in NFSD source files. This organization introduces brittleness that makes it difficult to execute changes that cut across layers and internal modules that might otherwise be cleanly siloed. It also pulls in unused items into each TU, making compilation of nfsd.ko needlessly slower and more computationally- expensive.

This series begins sorting through this pile to relocate items that are obviously better placed in NFS version- or task-specific headers.

Chuck Lever (9):
NFSD: Make "stats.h" self-contained
NFSD: Explicitly include "stats.h"
NFSD: include "netns.h"
NFSD: Remove '#include "nfsd.h"' from fs/nfsd/cache.h
NFSD: Move the export.h include from nfsd.h to auth.c
NFSD: Move struct readdir_cd
NFSD: Relocate nfsd_user_namespace()
NFSD: Relocate nfsd4_set_netaddr()
NFSD: Relocate NFSv4 "supported attributes" to new header

 fs/nfsd/attr4.h     | 162 +++++++++++++++++++++++++++++++++++
 fs/nfsd/auth.c      |  19 +++++
 fs/nfsd/auth.h      |   6 ++
 fs/nfsd/cache.h     |   3 +-
 fs/nfsd/nfs4idmap.c |   1 +
 fs/nfsd/nfs4proc.c  |  32 +++++++
 fs/nfsd/nfs4state.c |   1 +
 fs/nfsd/nfs4xdr.c   |   2 +
 fs/nfsd/nfscache.c  |   2 +
 fs/nfsd/nfsctl.c    |   2 +
 fs/nfsd/nfsd.h      | 202 +-------------------------------------------
 fs/nfsd/nfsfh.c     |   2 +
 fs/nfsd/nfsxdr.c    |   2 +
 fs/nfsd/state.h     |   3 +
 fs/nfsd/stats.c     |   2 +
 fs/nfsd/stats.h     |   3 +
 fs/nfsd/trace.h     |   1 +
 fs/nfsd/vfs.c       |   2 +
 fs/nfsd/vfs.h       |   5 +-
 fs/nfsd/xdr.h       |   1 +
 fs/nfsd/xdr3.h      |   1 +
 fs/nfsd/xdr4.h      |   2 +-
 22 files changed, 253 insertions(+), 203 deletions(-)
 create mode 100644 fs/nfsd/attr4.h
Signature · 1 line
2.54.0