Skip to content

spi: axiado: cond_no_effect and kernel-doc fixes

Babanpreet Singh linux-arm-kernel linux-spi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2spi: axiado: merge identical if/else branches in ax_transfer_one()drivers/spi/spi-axiado.c+4 -82 replies
2/2spi: axiado: fix kernel-doc commentsdrivers/spi/spi-axiado.c drivers/spi/spi-axiado.h+9 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSwark YangTzu-Hao Wei
1/2T-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] spi: axiado: cond_no_effect and kernel-doc fixes

Two small cleanups for the Axiado SPI driver, both defects present since the driver was added in e75a6b00ad79 ("spi: axiado: Add driver for Axiado SPI DB controller").

Patch 1 addresses the coccinelle cond_no_effect warning reported by the kernel test robot on 2026-07-12 [1]: the RX-only/full-duplex else-if arm and the trailing else arm in ax_transfer_one() have identical bodies, so the second condition has no effect. The arms are merged; no functional change (on x86_64/gcc 14, only ax_transfer_one()'s object code changes, dropping the dead condition evaluation).

Patch 2 fixes the kernel-doc comments in the driver: a copy-pasted function name on ax_spi_get_rx_byte_for_irq(), a /** block with no identifier line on ax_spi_process_rx_and_finalize(), and stale/missing member documentation on struct ax_spi. This silences the driver's two W=1 kernel-doc warnings plus five more visible when kernel-doc is run on the header directly.

Both patches are against spi/for-next; they are independent of each other except for touching the same file.

[1] https://lore.kernel.org/r/[email protected]/

Babanpreet Singh (2):
spi: axiado: merge identical if/else branches in ax_transfer_one()
spi: axiado: fix kernel-doc comments

 drivers/spi/spi-axiado.c | 20 ++++++++++----------
 drivers/spi/spi-axiado.h |  5 +++--
 2 files changed, 13 insertions(+), 12 deletions(-)

base-commit: 5f1b513690edf51727e6928b97705b6437f9a98e

Signature · 1 line
2.43.0