Skip to content

RFC mptcp: fallback to TCP on MP_FAIL with a single subflow

Chenguang Zhao mptcp 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest3 patches 1 replyIn review
  2. v4 RFC2 patches 6 repliesSuperseded
  3. v34 patches 20 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches3 repliesSuperseded
v11 patch1 replySuperseded

v4 from the cover letter

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: add MPFailFallback MIB counternet/mptcp/mib.c net/mptcp/mib.h+2 -00 replies
2/3mptcp: fallback immediately on MP_FAIL receptionnet/mptcp/pm.c net/mptcp/protocol.c+6 -70 replies
3/3mptcp: reject new subflows after fallbacknet/mptcp/subflow.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH mptcp-next RFC v5 0/3] mptcp: fallback to TCP on MP_FAIL with a single subflow

From: Chenguang Zhao <[email protected]>

Patch1:
Add MPFailFallback MIB counter

Patch2:
Move the FALLBACK_DONE flag setting to right after MP_FAIL is received.

Patch3:
Add a __mptcp_check_fallback() check inside mptcp_can_accept_new_subflow() to reject MP_JOIN requests earlier.

I have tested with the script from the linked URL, and the kernel is now able to reject MP_JOIN requests early.
https://github.com/chrisocean716-star/packetdrill/blob/fed57fab92c407eb433acdb8c8ce72bd8e3e2f37/gtests/net/mptcp/mp_join/mp_join_server_after_fallback.pkt

Chenguang Zhao (3):
mptcp: add MPFailFallback MIB counter
mptcp: fallback immediately on MP_FAIL reception
mptcp: reject new subflows after fallback

 net/mptcp/mib.c      | 1 +
 net/mptcp/mib.h      | 1 +
 net/mptcp/pm.c       | 5 +++++
 net/mptcp/protocol.c | 8 +-------
 net/mptcp/subflow.c  | 1 +
 5 files changed, 9 insertions(+), 7 deletions(-)

v4:
https://lore.kernel.org/all/[email protected]/

v3:
https://lore.kernel.org/all/[email protected]/

v2:
https://lore.kernel.org/all/[email protected]/

v1:
https://lore.kernel.org/all/[email protected]/

Signature · 1 line
2.25.1