Skip to content

staging: rtl8723bs: convert xmit helpers to return errno

Hungyu Lin linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: rtl8723bs: remove redundant return variable in rtw_make_wlanhdr()drivers/staging/rtl8723bs/core/rtw_xmit.c+2 -50 replies
2/5staging: rtl8723bs: convert rtw_make_wlanhdr() to return errnodrivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/include/rtw_xmit.h+9 -81 reply
3/5staging: rtl8723bs: convert xmitframe_addmic() to return errnodrivers/staging/rtl8723bs/core/rtw_xmit.c+6 -50 replies
4/5staging: rtl8723bs: simplify rtw_xmitframe_coalesce() control flowdrivers/staging/rtl8723bs/core/rtw_xmit.c+5 -110 replies
5/5staging: rtl8723bs: convert rtw_xmitframe_coalesce() to return errnodrivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c drivers/staging/rtl8723bs/include/rtw_xmit.h+7 -70 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] staging: rtl8723bs: convert xmit helpers to return errno

This series first simplifies control flow in rtw_make_wlanhdr() and rtw_xmitframe_coalesce() by removing redundant return variables and goto-based error handling. It then converts rtw_make_wlanhdr(), xmitframe_addmic(), and rtw_xmitframe_coalesce() to return errno values while propagating errno values through the caller chain.

Hungyu Lin (5):
staging: rtl8723bs: remove redundant return variable in
rtw_make_wlanhdr()
staging: rtl8723bs: convert rtw_make_wlanhdr() to return errno
staging: rtl8723bs: convert xmitframe_addmic() to return errno
staging: rtl8723bs: simplify rtw_xmitframe_coalesce() control flow
staging: rtl8723bs: convert rtw_xmitframe_coalesce() to return errno

 drivers/staging/rtl8723bs/core/rtw_xmit.c     | 45 ++++++++-----------
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  2 +-
 drivers/staging/rtl8723bs/include/rtw_xmit.h  |  4 +-
 3 files changed, 22 insertions(+), 29 deletions(-)
Signature · 1 line
2.43.0