Skip to content

target/s390x: Allow 2G hugepages guest backing

Claudio Imbrenda qemu-devel 3 versions – Applied

Status from this message: Thanks! Applied for 11.2

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 2 repliesApplied
  2. v21 patch 4 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

* Remove dead code introduced in the previous version.
* Factor out the capability enablement and error reporting to avoid duplicating code and error messages.
* Optimize the control flow and bring it back in line with the previous behaviour regarding page sizes, i.e. assuming that if the page size is neither 4K nor 1M, then it must be 2G.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/1target/s390x: Allow 2G hugepages guest backingtarget/s390x/diag.c target/s390x/kvm/kvm.c target/s390x/kvm/kvm_s390x.h +1 more+20 -221 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchEric FarmanHendrik BruecknerMatthew Rosato
1/1R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/1] target/s390x: Allow 2G hugepages guest backing

Allow mapping guest with 2G hugepages on hosts that support it.

Add new helper functions to check whether hpages are in effect, and which size.

v2->v3:
* Remove dead code introduced in the previous version.
* Factor out the capability enablement and error reporting to avoid duplicating code and error messages.
* Optimize the control flow and bring it back in line with the previous behaviour regarding page sizes, i.e. assuming that if the page size is neither 4K nor 1M, then it must be 2G.

v1->v2:
* Rename the global variable to cap_hpage
* Use different values of cap_hpage to distinguish between hpage sizes
* Add wrappers to test for specific hpage sizes

Claudio Imbrenda (1):
target/s390x: Allow 2G hugepages guest backing

 target/s390x/diag.c          |  2 +-
 target/s390x/kvm/kvm.c       | 36 +++++++++++++++++-------------------
 target/s390x/kvm/kvm_s390x.h |  2 +-
 target/s390x/kvm/stubs.c     |  2 +-
 4 files changed, 20 insertions(+), 22 deletions(-)
Signature · 1 line
2.55.0