Skip to content

KVM s390x PCI fixes

Farhan Ali kvm linux-s390 lkml stable 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 3 repliesIn review
  2. v56 patches 3 repliesSuperseded
  3. v46 patches 21 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches0 repliesSuperseded
v24 patches0 repliesSuperseded
v15 patches0 repliesSuperseded

Changes in v6 from the cover letter

- Fix the AIBV calculation (patch 6).

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6KVM: s390: pci: Reject adapter interrupt forwarding if already enabledarch/s390/kvm/pci.c+4 -00 replies
2/6KVM: s390: pci: Fix memory accounting for pinned/unpinned pagesarch/s390/kvm/pci.c arch/s390/kvm/pci.h+34 -111 reply
3/6KVM: s390: pci: Fix missing error codes and memory unaccountingarch/s390/kvm/pci.c+7 -20 replies
4/6KVM: s390: pci: Fix NULL dereference on AIBV allocation failurearch/s390/kvm/pci.c+8 -00 replies
5/6KVM: s390: pci: Fix resource leak on IRQ registration failurearch/s390/kvm/pci.c+21 -80 replies
6/6KVM: s390: pci: Validate AIBV and AISB before pinning guest pagesarch/s390/kvm/pci.c+15 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerMatthew Rosato
SeriesT-b
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/6] KVM s390x PCI fixes

Hi,

This series attempts to fix some the pre-existing issues[1] found by sashiko.

[1] https://lore.kernel.org/all/[email protected]/

Thanks
Farhan

ChangeLog
---------
v5: https://lore.kernel.org/all/[email protected]/
v5 -> v6
- Fix the AIBV calculation (patch 6).

v4: https://lore.kernel.org/all/[email protected]/
v4 -> v5
- Fix off by one error (patch 6).
- Add check for current->mm in account_mem() (patch 2).
- Fix commit message as suggested by Matt (patch 3, 4, 5).

v3: https://lore.kernel.org/all/[email protected]/
v3 -> v4
- Add validation checks for AISB/AIBV spanning more than a page.
- Reject multiple ioctl call for the same device, if adapter interrupt forwarding is already enabled for the device.
- Rebase on 7.2-rc4.

v2: https://lore.kernel.org/all/[email protected]/
v2 -> v3
- Remove overwriting guest FIB since we don't use it for re-issue (patch 4).

v1: https://lore.kernel.org/all/[email protected]/
v1 -> v2
- Drop fix handling AISB/AIBV spanning multiple pages.
- Fix memory accounting functions for the case when interrupt forwarding is enabled by one process but disabled by a different process (patch 1).

Farhan Ali (6):
KVM: s390: pci: Reject adapter interrupt forwarding if already enabled
KVM: s390: pci: Fix memory accounting for pinned/unpinned pages
KVM: s390: pci: Fix missing error codes and memory unaccounting
KVM: s390: pci: Fix NULL dereference on AIBV allocation failure
KVM: s390: pci: Fix resource leak on IRQ registration failure
KVM: s390: pci: Validate AIBV and AISB before pinning guest pages

 arch/s390/kvm/pci.c | 107 +++++++++++++++++++++++++++++++++++---------
 arch/s390/kvm/pci.h |   2 +
 2 files changed, 88 insertions(+), 21 deletions(-)
Signature · 1 line
2.43.0