Skip to content

net: Use synchronous wakeups selectively

Srikar Dronamraju linux-sctp lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net/socket: Record preference for synchronous wakeupsinclude/net/sock.h net/socket.c+49 -82 replies
2/2net/sock: Propagate WF_SYNC only when requestednet/core/sock.c net/sctp/socket.c net/smc/af_smc.c +3 more+77 -261 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] net: Use synchronous wakeups selectively

The scheduler assumes in several wakeup paths that a task using WF_SYNC is likely to yield the CPU shortly. However several networking wakeup paths unconditionally use synchronous wakeups even when the waking task continues execution.

During wakeup, with WF_SYNC flag set, because of the assumption that current thread is ready to give up, the wakee thread will be migrated from any core within the chip to the current LLC. If these operations are frequent, and wakers are actually not going away, then it will lead to load imbalance and hurt performance. This is especially true in architectures where LLCs are small and number of LLCs per chip are more.

Running vllm workload was run on Power10 system

                                  No patch      with patch %diff
Inference Time (sec)              17.84         16.35     -8.35%
llm query bandwidth (tokens/sec)  14.78         16.21     +9.68%

Lower inference time and higher tokens/sec is better.

Srikar Dronamraju (2):
net/socket: Record preference for synchronous wakeups net/sock: Propagate WF_SYNC only when requested

 include/net/sock.h |  1 +
 net/core/sock.c    | 31 +++++++++++++++++++------
 net/sctp/socket.c  | 10 +++++++--
 net/smc/af_smc.c   |  4 ++--
 net/smc/smc_rx.c   | 10 +++++++--
 net/socket.c       | 56 +++++++++++++++++++++++++++++++++++++++-------
 net/tipc/socket.c  | 22 +++++++++++++-----
 net/unix/af_unix.c | 26 ++++++++++++++-------
 8 files changed, 126 insertions(+), 34 deletions(-)
Signature · 1 line
2.51.0