Skip to content

ASoC: ti: Improve probe error handling

[email protected] linux-omap linux-sound lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 8 repliesIn review
  2. v210 patches 6 repliesSuperseded
  3. v110 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Add the remaining missing parentheses to snd_soc_register_card() (Cezary).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ASoC: ti: ams-delta: Use dev_err_probe() for error handlingsound/soc/ti/ams-delta.c+2 -20 replies
2/10ASoC: ti: davinci-evm: Use dev_err_probe() for error handlingsound/soc/ti/davinci-evm.c+1 -20 replies
3/10ASoC: ti: j721e-evm: Return the original error from card name parsingsound/soc/ti/j721e-evm.c+3 -40 replies
4/10ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant logsound/soc/ti/omap-abe-twl6040.c+4 -71 reply
5/10ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handlingsound/soc/ti/omap-abe-twl6040.c+2 -21 reply
6/10ASoC: ti: omap-dmic: Use dev_err_probe() for error handlingsound/soc/ti/omap-dmic.c+3 -41 reply
7/10ASoC: ti: omap-hdmi: Use dev_err_probe() for error handlingsound/soc/ti/omap-hdmi.c+2 -41 reply
8/10ASoC: ti: omap-twl4030: Return the original error codesound/soc/ti/omap-twl4030.c+3 -41 reply
9/10ASoC: ti: omap-twl4030: Use dev_err_probe() for error handlingsound/soc/ti/omap-twl4030.c+3 -51 reply
10/10ASoC: ti: rx51: Use dev_err_probe() for error handlingsound/soc/ti/rx51.c+12 -161 reply

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchJarkko Nikula
1/10
2/10
3/10
4/10A-b
5/10A-b
6/10A-b
7/10A-b
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] ASoC: ti: Improve probe error handling

From: bui duc phuc <[email protected]>

Hi all,

This series cleans up probe error handling across several TI ASoC drivers.

The changes fall into two categories:
1.Replace dev_err() with dev_err_probe() when reporting probe
failures. This preserves the original error code while suppressing unnecessary log messages for deferred probe errors.
2.Preserve the original error codes returned by helper functions
instead of converting them to -ENODEV, and remove redundant error messages where the helper already reports the failure.

Build-tested only.

Changes in v2:
- Add missing parentheses to snd_soc_register_card() (Christophe).
- Remove an extra blank line (Christophe).
Changes in v3:
- Add the remaining missing parentheses to snd_soc_register_card() (Cezary).

Best regards,
Phuc

bui duc phuc (10):
ASoC: ti: ams-delta: Use dev_err_probe() for error handling
ASoC: ti: davinci-evm: Use dev_err_probe() for error handling
ASoC: ti: j721e-evm: Return the original error from card name parsing
ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log
ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling
ASoC: ti: omap-dmic: Use dev_err_probe() for error handling
ASoC: ti: omap-hdmi: Use dev_err_probe() for error handling
ASoC: ti: omap-twl4030: Return the original error code
ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling
ASoC: ti: rx51: Use dev_err_probe() for error handling

 sound/soc/ti/ams-delta.c        |  4 ++--
 sound/soc/ti/davinci-evm.c      |  3 +--
 sound/soc/ti/j721e-evm.c        |  7 +++----
 sound/soc/ti/omap-abe-twl6040.c | 15 ++++++---------
 sound/soc/ti/omap-dmic.c        |  7 +++----
 sound/soc/ti/omap-hdmi.c        |  6 ++----
 sound/soc/ti/omap-twl4030.c     | 15 ++++++---------
 sound/soc/ti/rx51.c             | 28 ++++++++++++----------------
 8 files changed, 35 insertions(+), 50 deletions(-)
Signature · 1 line
2.43.0