Skip to content

tempfile: stop using the_repository

René Scharfe git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tempfile: add repo_create_tempfile{,_mode}()tempfile.c tempfile.h+18 -12 replies
2/5refs/packed: use repo_create_tempfile()refs/packed-backend.c+1 -10 replies
3/5lockfile: add repo_hold_lock_file_for_update{,_timeout}{,_mode}()lockfile.c lockfile.h+53 -80 replies
4/5tempfile: stop using the_repositorytempfile.c tempfile.h+0 -141 reply
5/5use repo_hold_lock_file_for_update{,_mode,_timeout}() with custom reposapply.c builtin/difftool.c builtin/gc.c +14 more+46 -364 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] tempfile: stop using the_repository

create_tempfile_mode() and create_tempfile() use the_repository internally to call adjust_shared_perm(). Expose that dependency and push it out to their callers.

Patch 5 is a bonus; it converts lockfile users that already work with other repositories.

tempfile: add repo_create_tempfile{,_mode}()
refs/packed: use repo_create_tempfile()
lockfile: add repo_hold_lock_file_for_update{,_timeout}{,_mode}()
tempfile: stop using the_repository
use repo_hold_lock_file_for_update{,_mode,_timeout}() with custom repos

 apply.c                   | 10 ++++++----
 builtin/difftool.c        |  2 +-
 builtin/gc.c              |  2 +-
 builtin/history.c         |  2 +-
 builtin/sparse-checkout.c |  3 ++-
 bundle.c                  |  4 ++--
 commit-graph.c            |  9 +++++----
 config.c                  |  4 ++--
 lockfile.c                | 30 ++++++++++++++++++++++--------
 lockfile.h                | 31 +++++++++++++++++++++++++++++++
 loose.c                   |  6 ++++--
 midx-write.c              |  7 ++++---
 odb/source-files.c        |  3 ++-
 refs/files-backend.c      | 10 ++++++----
 refs/packed-backend.c     |  9 ++++-----
 refs/packed-backend.h     |  2 +-
 repack-midx.c             |  3 ++-
 repository.c              |  2 +-
 rerere.c                  |  6 +++---
 tempfile.c                |  7 +++----
 tempfile.h                | 10 +++++++---
 21 files changed, 110 insertions(+), 52 deletions(-)
Signature · 1 line
2.55.0