Skip to content

dma: fsl_raid: fix sparse warnings and simplify probing

Rosen Penev dmaengine lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesApplied
  2. v13 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4dma: fsl_raid: convert descriptor stores to big-endiandrivers/dma/fsl_raid.c+7 -61 reply
2/4dma: fsl_raid: set final bit via fill_cfd_frame() argumentdrivers/dma/fsl_raid.c+8 -81 reply
3/4dma: fsl_raid: keep MMIO bases as void __iomem and cast at accessdrivers/dma/fsl_raid.c drivers/dma/fsl_raid.h+12 -111 reply
4/4dma: fsl_raid: use devm_platform_ioremap_resourcedrivers/dma/fsl_raid.c+5 -90 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFrank Li
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/4] dma: fsl_raid: fix sparse warnings and simplify probing

This series cleans up the fsl_raid driver to address issues reported by sparse and to simplify its MMIO handling.

Patch 1 fixes the endianness of in-memory descriptor stores. The descriptor structs are handed to the device as big-endian, but the driver stored CPU-endian values directly, which is both incorrect and flagged by sparse as a base-type mismatch. The stores are wrapped in cpu_to_be32() and the final-frame bit is now passed as an argument rather than read-modify-written.

Patch 2 keeps the MMIO bases (re_regs and jrregs) as void __iomem * instead of typed register struct pointers, eliminating "different address spaces" sparse warnings on every register access. Each accessor derives a local __iomem-qualified typed pointer.

Patch 3 replaces the open-coded platform_get_resource() + devm_ioremap() sequence with devm_platform_ioremap_resource().

v2: split up first patch and simplify __iomem patch.

Rosen Penev (4):
dma: fsl_raid: convert descriptor stores to big-endian
dma: fsl_raid: set final bit via fill_cfd_frame() argument
dma: fsl_raid: keep MMIO bases as void __iomem and cast at access
dma: fsl_raid: use devm_platform_ioremap_resource

 drivers/dma/fsl_raid.c | 58 ++++++++++++++++++++----------------------
 drivers/dma/fsl_raid.h |  4 +--
 2 files changed, 30 insertions(+), 32 deletions(-)
Signature · 1 line
2.55.0