Skip to content

drm/amdgpu: Support DRM format modifiers on GFX6-8 (v2)

Timur Kristóf amd-gfx dri-devel sashiko-reviews 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/fourcc: Add modifiers for AMD GFX6-8include/uapi/drm/drm_fourcc.h+191 -181 reply
2/4drm/amdgpu: Convert tiling flags to modifiers on GFX6-8drivers/gpu/drm/amd/amdgpu/amdgpu_display.c+108 -31 reply
3/4drm/amd/display: Support DRM format modifiers on GFX6-8drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c+309 -71 reply
4/4drm/amd/display: Don't use tiling flags anymoredrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h +1 more+2 -1511 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarek OlšákDaniel StoneAlex DeucherLink MauveNikola Medić
1/4R-b R-b R-b
2/4R-b R-b R-b T-b T-b
3/4R-b R-b R-b T-b T-b
4/4R-b R-b R-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] drm/amdgpu: Support DRM format modifiers on GFX6-8 (v2)

GFX6-8 are the oldest GPUs supported by the amdgpu kernel driver, and the last ones that didn't support DRM format modifiers until now.

On GFX6-8, the GFX block can only use pre-determined tiling modes which are programmed by the kernel according to the tiling mode table. The new modifiers encode all the details needed for tiling on these GPUs.

For the exact details, see the commit message of:
"drm/fourcc: Add modifiers for AMD GFX6-8"

For a userspace implementation, see this Mesa MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41557
And for libdrm:
https://gitlab.freedesktop.org/mesa/libdrm/-/merge_requests/481

Supporting DRM format modifiers on GFX6-8 will unblock many things in the Linux graphics ecosystem that previously either didn't work on these GPUs or had to implement fallbacks.
For example, compositors written in Vulkan or compositors running on Zink, interop between different APIs (eg. VAAPI / OpenGL / Vulkan) etc.

Timur Kristóf (4):
drm/fourcc: Add modifiers for AMD GFX6-8 drm/amdgpu: Convert tiling flags to modifiers on GFX6-8 drm/amd/display: Support DRM format modifiers on GFX6-8 drm/amd/display: Don't use tiling flags anymore

 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   | 111 +++++-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  29 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_plane.c   | 337 ++++++++++++++++--
 .../amd/display/amdgpu_dm/amdgpu_dm_plane.h   |   3 -
 .../amdgpu_dm/tests/amdgpu_dm_plane_test.c    |  84 -----
 include/uapi/drm/drm_fourcc.h                 | 209 ++++++++++-
 6 files changed, 602 insertions(+), 171 deletions(-)
Signature · 1 line
2.55.0