ksparser: four argparse-type fixes plus unit coverage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ksparser: reject negative sizes in sizetype()src/ | +2 | 0 replies | |
| 2/5 | ksparser: fix crash on out-of-range overhead factorsrc/ | +1 | 0 replies | |
| 3/5 | ksparser: reject non-finite overhead factorssrc/ | +2 | 0 replies | |
| 4/5 | ksparser: require an explicit 0x prefix for --system-idsrc/ | +5 | 0 replies | |
| 5/5 | tests/unit/test_ksparser_types: cover ksparser's argparse typestests/ | +226 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paul Barker |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [wic][PATCH 0/5] ksparser: four argparse-type fixes plus unit coverage
This series continues the standalone unit-test work, this time over the custom argparse types in ksparser.py: sizetype(), overheadtype(), and systemidtype(). It keeps the shape the suite settled on: each source fix is its own standalone commit, and the green test module lands last, so the suite passes at every commit.
Four fixes come first, each independent of the others:
- sizetype() accepted a leading minus, so "-1M" returned -1024 and "-5" returned -5120. A negative size is meaningless for every consumer (--size, --fixed-size, --offset, --extra-*-space, the empty source plugin's size=/bs=); reject it.
- overheadtype()'s below-1.0 error path did "...message..." % arg with no %-placeholder, so every out-of-range value crashed with an opaque TypeError instead of the intended ArgumentTypeError. Add the missing placeholder.
- overheadtype() let float('nan') and float('inf') slip past the < 1.0 guard, which then multiplied the rootfs size by nan/inf downstream. Reject any non-finite factor up front.
- systemidtype() converted with int(arg, 16), which also accepts a
bare "82" (hex 130) and a signed "+0x82", contradicting its
documented "hex between 0x1 and 0xFF" contract. Require an explicit
0x prefix.The final commit adds tests/unit/test_ksparser_types.py, covering the three types' accepted forms, boundaries, and rejected inputs, and locking in the four fixes. Backing any fix out turns the matching test red. The suite is green at every commit and ruff-clean.
Trevor Woerner (5):
ksparser: reject negative sizes in sizetype()
ksparser: fix crash on out-of-range overhead factor
ksparser: reject non-finite overhead factors
ksparser: require an explicit 0x prefix for --system-id tests/unit/test_ksparser_types: cover ksparser's argparse types
src/wic/ksparser.py | 15 +- tests/unit/test_ksparser_types.py | 226 ++++++++++++++++++++++++++++++ 2 files changed, 236 insertions(+), 5 deletions(-) create mode 100644 tests/unit/test_ksparser_types.py
Signature · 1 line
2.50.0.173.g8b6f19ccfc3a