Skip to content

IIO: Clean out superfluous I2C checks for single transfers

Jonathan Cameron linux-i2c linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22iio: adc: ltc2471: Remove redundant i2c_master_recv() length checkdrivers/iio/adc/ltc2471.c+0 -20 replies
2/22iio: adc: ti-ads7138: Remove redundant i2c_master_send() length checksdrivers/iio/adc/ti-ads7138.c+0 -40 replies
3/22iio: adc: versal-sysmon: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/adc/versal-sysmon-i2c.c+0 -60 replies
4/22iio: chemical: scd30: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/chemical/scd30_i2c.c+0 -41 reply
5/22iio: chemical: scd4x: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/chemical/scd4x.c+0 -80 replies
6/22iio: chemical: sgp30: Remove redundant i2c_master_recv() length checkdrivers/iio/chemical/sgp30.c+0 -20 replies
7/22iio: chemical: sgp40: Remove redundant i2c_master_recv() length checkdrivers/iio/chemical/sgp40.c+0 -40 replies
8/22iio: chemical: sps30: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/chemical/sps30_i2c.c+0 -40 replies
9/22iio: dac: ad5446: Remove redundant i2c_master_send() length checkdrivers/iio/dac/ad5446-i2c.c+0 -20 replies
10/22iio: dac: ad5696: Remove redundant i2c_master_send() length checkdrivers/iio/dac/ad5696-i2c.c+1 -10 replies
11/22iio: dac: m62332: Remove redundant i2c_master_send() length checkdrivers/iio/dac/m62332.c+0 -20 replies
12/22iio: dac: max517: Remove redundant i2c_master_send() length checkdrivers/iio/dac/max517.c+2 -41 reply
13/22iio: dac: max5821: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/dac/max5821.c+2 -120 replies
14/22iio: dac: mcp4725: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/dac/mcp4725.c+6 -160 replies
15/22iio: dac: mcp4728: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/dac/mcp4728.c+1 -120 replies
16/22iio: light: lv0104cs: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/light/lv0104cs.c+0 -40 replies
17/22iio: potentiometer: ad5110: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/potentiometer/ad5110.c+3 -150 replies
18/22iio: pressure: abp2030pa: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/pressure/abp2030pa_i2c.c+0 -40 replies
19/22iio: pressure: adp810: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/pressure/adp810.c+0 -40 replies
20/22iio: pressure: icp10100: Remove redundant i2c_master_send() length checkdrivers/iio/pressure/icp10100.c+0 -20 replies
21/22iio: pressure: mprls0025pa: Remove redundant i2c_master_{send,recv}() length checksdrivers/iio/pressure/mprls0025pa_i2c.c+0 -40 replies
22/22iio: pressure: sdp500: Remove redundant i2c_master_recv() length checkdrivers/iio/pressure/sdp500.c+0 -40 replies

Reviews trailers per patch

None of the 22 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJoshua CroftsNuno Sá
SeriesR-b R-b
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RESEND PATCH 00/22] IIO: Clean out superfluous I2C checks for single transfers

Resend to include linux-iio. Sorry to all who get it twice.

This came up in a recent review and I realised I have been giving incorrect review feedback for years. Both i2_master_send() and i2c_master_recv() plus the dma safe variants only ever return either an error or the full buffer size. Short accesses do not occur.

This series (also my first upstream series prepared by poking claude) removes the redundant checks from all IIO drivers.

Thanks,

Jonathan

Jonathan Cameron (22):
iio: adc: ltc2471: Remove redundant i2c_master_recv() length check
iio: adc: ti-ads7138: Remove redundant i2c_master_send() length checks
iio: adc: versal-sysmon: Remove redundant i2c_master_{send,recv}()
length checks
iio: chemical: scd30: Remove redundant i2c_master_{send,recv}() length
checks
iio: chemical: scd4x: Remove redundant i2c_master_{send,recv}() length
checks
iio: chemical: sgp30: Remove redundant i2c_master_recv() length check
iio: chemical: sgp40: Remove redundant i2c_master_recv() length check
iio: chemical: sps30: Remove redundant i2c_master_{send,recv}() length
checks
iio: dac: ad5446: Remove redundant i2c_master_send() length check
iio: dac: ad5696: Remove redundant i2c_master_send() length check
iio: dac: m62332: Remove redundant i2c_master_send() length check
iio: dac: max517: Remove redundant i2c_master_send() length check
iio: dac: max5821: Remove redundant i2c_master_{send,recv}() length
checks
iio: dac: mcp4725: Remove redundant i2c_master_{send,recv}() length
checks
iio: dac: mcp4728: Remove redundant i2c_master_{send,recv}() length
checks
iio: light: lv0104cs: Remove redundant i2c_master_{send,recv}() length
checks
iio: potentiometer: ad5110: Remove redundant i2c_master_{send,recv}()
length checks
iio: pressure: abp2030pa: Remove redundant i2c_master_{send,recv}()
length checks
iio: pressure: adp810: Remove redundant i2c_master_{send,recv}()
length checks
iio: pressure: icp10100: Remove redundant i2c_master_send() length
check
iio: pressure: mprls0025pa: Remove redundant i2c_master_{send,recv}()
length checks
iio: pressure: sdp500: Remove redundant i2c_master_recv() length check

 drivers/iio/adc/ltc2471.c              |  2 --
 drivers/iio/adc/ti-ads7138.c           |  4 ----
 drivers/iio/adc/versal-sysmon-i2c.c    |  6 ------
 drivers/iio/chemical/scd30_i2c.c       |  4 ----
 drivers/iio/chemical/scd4x.c           |  8 --------
 drivers/iio/chemical/sgp30.c           |  2 --
 drivers/iio/chemical/sgp40.c           |  4 ----
 drivers/iio/chemical/sps30_i2c.c       |  4 ----
 drivers/iio/dac/ad5446-i2c.c           |  2 --
 drivers/iio/dac/ad5696-i2c.c           |  2 +-
 drivers/iio/dac/m62332.c               |  2 --
 drivers/iio/dac/max517.c               |  6 ++----
 drivers/iio/dac/max5821.c              | 14 ++------------
 drivers/iio/dac/mcp4725.c              | 22 ++++++----------------
 drivers/iio/dac/mcp4728.c              | 13 +------------
 drivers/iio/light/lv0104cs.c           |  4 ----
 drivers/iio/potentiometer/ad5110.c     | 18 +++---------------
 drivers/iio/pressure/abp2030pa_i2c.c   |  4 ----
 drivers/iio/pressure/adp810.c          |  4 ----
 drivers/iio/pressure/icp10100.c        |  2 --
 drivers/iio/pressure/mprls0025pa_i2c.c |  4 ----
 drivers/iio/pressure/sdp500.c          |  4 ----
 22 files changed, 15 insertions(+), 120 deletions(-)
Signature · 1 line
2.43.0