Skip to content

Add reset support to MT6589 wdt and remove fallback compatibles

Akari Tsuyukusa linux-arm-kernel linux-devicetree linux-mediatek linux-watchdog lkml 1 version NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/7watchdog: mtk_wdt: add explicit compatibles for SoCs using mt6589 fallbackdrivers/watchdog/mtk_wdt.c+11 -01 reply
2/7dt-bindings: watchdog: mediatek,mtk-wdt: add compatibles for all SoCsDocumentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml+11 -01 reply
3/7arm/arm64: dts: mediatek: drop mt6589 fallback from watchdogarch/arm/boot/dts/mediatek/mt2701.dtsi arch/arm/boot/dts/mediatek/mt6572.dtsi arch/arm/boot/dts/mediatek/mt6582.dtsi +7 more+10 -161 reply
4/7dt-bindings: watchdog: mediatek,mtk-wdt: remove mt6589 fallback itemsDocumentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml+0 -151 reply
5/7dt-bindings: reset: Add bindings for MediaTek MT6589 reset controllerinclude/dt-bindings/reset/mt6589-resets.h+25 -01 reply
6/7watchdog: mtk_wdt: add reset controller support for MT6589drivers/watchdog/mtk_wdt.c+6 -10 replies
7/7arm: dts: mediatek: mt6589: add reset support for wdtarch/arm/boot/dts/mediatek/mt6589.dtsi+1 -00 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchRoman Vivchar
1/7
2/7
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] Add reset support to MT6589 wdt and remove fallback compatibles

This series adds TOPRGU reset controller support to the MT6589 watchdog and removes the use of "mediatek,mt6589-wdt" as the fallback compatible from many other MediaTek SoCs.

Many SoCs have been using "mediatek,mt6589-wdt" as the fallback. However, they are not compatible with the MT6589's reset register.

To add reset support to MT6589 wdt and resolve this problem safely, the series proceeds step by step:

1. Add explicit driver entries for the affected SoCs,
so they can be matched directly.
2. Extend the dt-binding to accept the SoC-specific compatibles while still allowing the old fallback form.
3. Drop the mt6589 fallback from all in-tree DTS.
4. Remove the fallback from the dt-binding.
5. Add the MT6589 reset dt-binding header.
6. Assign reset data exclusively to the mt6589-wdt entry.
7. Add #reset-cells to the MT6589 to enable TOPRGU reset controller.

Akari Tsuyukusa (7):
watchdog: mtk_wdt: add explicit compatibles for SoCs using mt6589
fallback
dt-bindings: watchdog: mediatek,mtk-wdt: add compatibles for all SoCs arm/arm64: dts: mediatek: drop mt6589 fallback from watchdog
dt-bindings: watchdog: mediatek,mtk-wdt: remove mt6589 fallback items
dt-bindings: reset: Add bindings for MediaTek MT6589 reset controller
watchdog: mtk_wdt: add reset controller support for MT6589
arm: dts: mediatek: mt6589: add reset support for wdt

 .../bindings/watchdog/mediatek,mtk-wdt.yaml   | 26 ++++++++-----------
 arch/arm/boot/dts/mediatek/mt2701.dtsi        |  3 +--
 arch/arm/boot/dts/mediatek/mt6572.dtsi        |  2 +-
 arch/arm/boot/dts/mediatek/mt6582.dtsi        |  2 +-
 arch/arm/boot/dts/mediatek/mt6589.dtsi        |  1 +
 arch/arm/boot/dts/mediatek/mt7623.dtsi        |  3 +--
 arch/arm/boot/dts/mediatek/mt7629.dtsi        |  3 +--
 arch/arm64/boot/dts/mediatek/mt6797.dtsi      |  2 +-
 arch/arm64/boot/dts/mediatek/mt7622.dtsi      |  3 +--
 arch/arm64/boot/dts/mediatek/mt8173.dtsi      |  3 +--
 arch/arm64/boot/dts/mediatek/mt8365.dtsi      |  2 +-
 arch/arm64/boot/dts/mediatek/mt8516.dtsi      |  3 +--
 drivers/watchdog/mtk_wdt.c                    | 18 ++++++++++++-
 include/dt-bindings/reset/mt6589-resets.h     | 25 ++++++++++++++++++
 14 files changed, 64 insertions(+), 32 deletions(-)
 create mode 100644 include/dt-bindings/reset/mt6589-resets.h
Signature · 1 line
2.54.0