Skip to content

mmc: Add power_off_delay_us support

Judith Mendez linux-devicetree linux-mmc lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v23 patches 10 repliesSuperseded
  3. v12 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- allow 0us as lowest possible value (early return)
- Change custom logic in mmc_delay_us() to use fsleep()
- drop dt parsing checkers

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: mmc: Add power-off-delay-us propertyDocumentation/devicetree/bindings/mmc/mmc-controller-common.yaml+10 -00 replies
2/2mmc: core: Add power-off-delay-us supportdrivers/mmc/core/core.c drivers/mmc/core/core.h drivers/mmc/core/host.c +1 more+14 -10 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRob Herring (Arm)
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] mmc: Add power_off_delay_us support

This series adds power_off_delay_us support for MMC controllers, enabling boards to specify custom delays after MMC power off to work around hardware issues such as slow RC circuites on MMC VDD rails.

Rather than adding host driver-specific workarounds, we abstract the implementation into the MMC core and pickup the delay value with a device tree property (power-off-delay-us). This allows any board with slow power off requirements to configure the necessary delay without code changes.

The solution is minimal and follows existing patterns as with power_delay_ms. The allowed minimum value = 0 ms (early return). The default value is 1000us to not deviate from the original 1ms delay set in mmc_power_off().

Link to v1:
https://lore.kernel.org/all/[email protected]/
Link to v2:
https://lore.kernel.org/all/[email protected]/

Changes since v2:
- allow 0us as lowest possible value (early return)
- Change custom logic in mmc_delay_us() to use fsleep()
- drop dt parsing checkers

Judith Mendez (2):
dt-bindings: mmc: Add power-off-delay-us property
mmc: core: Add power-off-delay-us support

 .../devicetree/bindings/mmc/mmc-controller-common.yaml | 10 ++++++++++
 drivers/mmc/core/core.c                                |  2 +-
 drivers/mmc/core/core.h                                |  8 ++++++++
 drivers/mmc/core/host.c                                |  4 ++++
 include/linux/mmc/host.h                               |  1 +
 5 files changed, 24 insertions(+), 1 deletion(-)
Signature · 1 line
2.54.0