Skip to content

ACPI/PCC: Correct PCC OperationRegion handling

Sudeep Holla acpica-devel linux-acpi 3 versions – Applied

Status from this message: Applied as 7.4 material, but please note that Sashiko reports

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied
  2. v24 patches 5 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Updated the ACPICA patch to the version accepted as part of
https://github.com/acpica/acpica/pull/1205
- Rebased other patches to v7.3-rc4
- v2: https://lore.kernel.org/all/[email protected]/

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4ACPICA: Fix PCC OperationRegion command offsetsdrivers/acpi/acpica/exfield.c+6 -50 replies
2/4ACPI: PCC: Preserve shared memory signature in OpRegion handlerdrivers/acpi/acpi_pcc.c+16 -40 replies
3/4ACPI: PCC: Free channel on OpRegion deactivationdrivers/acpi/acpi_pcc.c+13 -00 replies
4/4ACPI: PCC: Cache OpRegion command timeoutdrivers/acpi/acpi_pcc.c+13 -90 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchHuisong Li
1/4
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] ACPI/PCC: Correct PCC OperationRegion handling

Hi,

This series corrects the handling of PCC OperationRegions and their shared memory.

ACPI 6.3 states that a PCC OperationRegion describes the shared memory following the PCC signature. Consequently, COMMAND fields at raw shared memory offsets 4 and 12 appear at OperationRegion offsets 0 and 8.

The first patch corrects those offsets in ACPICA. This change has already been submitted upstream:

https://github.com/acpica/acpica/pull/1205

The ACPICA patch is included here only to document the complete dependency and aid review and testing. It must enter the kernel through the ACPICA pull/import process and will not be merged directly through the Linux ACPI tree.

The remaining Linux patches:

- Preserve the platform-populated PCC signature when copying OperationRegion data.
- Release the mailbox channel and region context when ACPICA deactivates an OperationRegion.
- Compute and cache the command timeout during channel setup.

There is no strict build dependency in case ACPICA and other 3 changes need to be merged at different timeline or via different branch.

Regards,
Sudeep

---

Changes in v3:
- Updated the ACPICA patch to the version accepted as part of
https://github.com/acpica/acpica/pull/1205
- Rebased other patches to v7.3-rc4
- v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Updated the commit message to include correct example of PCC Opregion as the example added by original commit 77e2a04745ff ("ACPI: PCC:
Implement OperationRegion handler for the PCC Type 3 subtype") incorrectly included the signature as an OperationRegion field.
- v1: https://lore.kernel.org/all/[email protected]/

Sudeep Holla (4):
ACPICA: Fix PCC OperationRegion command offsets
ACPI: PCC: Preserve shared memory signature in OpRegion handler
ACPI: PCC: Free channel on OpRegion deactivation
ACPI: PCC: Cache OpRegion command timeout

 drivers/acpi/acpi_pcc.c       | 55 ++++++++++++++++++++++++++---------
 drivers/acpi/acpica/exfield.c | 11 +++----
 2 files changed, 48 insertions(+), 18 deletions(-)
Signature · 1 line
2.43.0