Skip to content

RFC review: track and browse every version of a tracked series

Christian Brauner tools 2 versions – New

Get series with b4
b4 am [email protected] change-id 20260718-work-b4-multiver-rows-6032fb71e951

Versions newest first

  1. v2 RFC Latest25 patches 0 repliesNew
  2. v1 RFC11 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Redesign the whole approach.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25review-tui: fix rethreaded series thread viewingsrc/b4/review_tui/_lite_app.py src/b4/review_tui/_tracking_app.py+2 -00 replies
2/25review: do not clear fields a re-adding caller does not knowsrc/b4/review/tracking.py+11 -30 replies
3/25review-tui: keep the rethread flag on an upgraded series rowsrc/b4/review/tracking.py src/b4/review_tui/_tracking_app.py+23 -30 replies
4/25review: guard the tracking-commit amend on the worktree, not the checkoutsrc/b4/__init__.py src/b4/review/_review.py src/b4/review/tracking.py+87 -00 replies
5/25review-tui: recompute an evicted A·R·T cache entrysrc/b4/review_tui/_tracking_app.py+31 -30 replies
6/25review: test the prerequisite fixessrc/tests/conftest.py src/tests/test___init__.py src/tests/test_review_tracking.py +1 more+492 -00 replies
7/25review: serialize schema migrations against a concurrent openersrc/b4/review/tracking.py+42 -20 replies
8/25review: test the migration serializationsrc/tests/test_review_tracking.py+113 -00 replies
9/25review: track message counts for all revisions of a seriessrc/b4/review/_review.py src/b4/review/tracking.py src/b4/review_tui/_tracking_app.py +2 more+1326 -2480 replies
10/25review: give per-change_id state its own tablesrc/b4/review/tracking.py src/tests/test_review_tracking.py+120 -240 replies
11/25review: test per-revision message trackingsrc/tests/test_review_tracking.py+2901 -10 replies
12/25review-tui: poll every revision on u/U updatessrc/b4/review/_review.py src/b4/review/tracking.py src/b4/review_tui/_common.py +4 more+331 -570 replies
13/25review: test the per-revision poll sweepsrc/tests/test_review.py src/tests/test_review_tracking.py src/tests/test_tui_tracking.py+998 -00 replies
14/25review-tui: resolve the tracked revision in revision listssrc/b4/review/tracking.py src/b4/review_tui/_common.py src/b4/review_tui/_tracking_app.py+139 -10 replies
15/25review-tui: fall back when a cached thread blob has no seriessrc/b4/review_tui/_common.py+136 -310 replies
16/25review-tui: test revision resolution and the range-diff fallbacksrc/tests/test_review_tracking.py src/tests/test_tui_review.py+378 -10 replies
17/25review: skip the catalog mirror when nothing movedsrc/b4/review/_review.py src/b4/review/tracking.py src/tests/test_review.py +1 more+131 -260 replies
18/25review: match a stray posting by message-idsrc/b4/review/tracking.py src/b4/review_tui/_tracking_app.py+102 -190 replies
19/25review: add backward discovery of older series revisionssrc/b4/review/_review.py src/b4/review/tracking.py+293 -150 replies
20/25review-tui: add a "Find older revisions" actiondocs/maintainer/review.rst src/b4/review_tui/_tracking_app.py+105 -00 replies
21/25review: test the catalog mirror, stray matching and backward discoverysrc/tests/test_review.py src/tests/test_review_tracking.py src/tests/test_tui_tracking.py+1792 -00 replies
22/25review-tui: extract the Msgs column renderer from TrackedSeriesItemsrc/b4/review_tui/_tracking_app.py+66 -410 replies
23/25review-tui: give the unseen badge a column of its ownsrc/b4/review_tui/_tracking_app.py+10 -30 replies
24/25review-tui: expand tracked series into per-version rowsdocs/maintainer/review.rst src/b4/review/tracking.py src/b4/review_tui/_modals.py +3 more+707 -1290 replies
25/25review-tui: test per-version tracker rowssrc/tests/test_tui_tracking.py+1626 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH RFC v2 00/25] review: track and browse every version of a tracked series

The review TUI binds all mail visibility to the revision a series is tracked at. 'e' opens only the tracked thread, unread badges exist only on the series row, and u/U updates poll only the tracked revision. Earlier versions of a series are invisible.

Make every known version of a tracked series a first-class citizen of the mail-tracking machinery.

The revisions catalog becomes the only home for per-revision read state (schema v11).

Per-change_id state moves the other way, onto a new changes table (schema v12). There is one b4/review/<change_id> branch, so its sha should not be stored once per version and read back with an ORDER BY. The catalog-sync and the backward-search live there too.

u/U updates poll every cataloged revision for new mail using the same thread queries used elsewhere. Neither lore nor b4 really support incremental updates though. Lore misses that functionality afaict.

A new "Find older revisions" action runs the b4 am/mbox backward search. It uses the change-id query when the cover carries one and subject+sender otherwise. It records what it finds and polls the new entries immediately. A retitled series without a change-id still needs manual linking. The same limitation b4 am -vN has.

The tracker list gains expandable per-version rows. 'x' unfolds a series into child rows. The tracked revision is starred. 'X' toggles all series at once. Enter or 'e' on a child opens that version's thread with revision-correct. 'd' range-diffs it against the tracked revision directly.

Message-level read state was already keyed by message-id alone. So Seen/Flagged/Answered flags apply across versions unchanged. This series adds the count, badge and navigation layers on top.

---
Changes in v2:
- Redesign the whole approach.

---
Christian Brauner (25):
review-tui: fix rethreaded series thread viewing
review: do not clear fields a re-adding caller does not know
review-tui: keep the rethread flag on an upgraded series row
review: guard the tracking-commit amend on the worktree, not the checkout
review-tui: recompute an evicted A·R·T cache entry
review: test the prerequisite fixes
review: serialize schema migrations against a concurrent opener
review: test the migration serialization
review: track message counts for all revisions of a series
review: give per-change_id state its own table
review: test per-revision message tracking
review-tui: poll every revision on u/U updates
review: test the per-revision poll sweep
review-tui: resolve the tracked revision in revision lists
review-tui: fall back when a cached thread blob has no series
review-tui: test revision resolution and the range-diff fallback
review: skip the catalog mirror when nothing moved
review: match a stray posting by message-id
review: add backward discovery of older series revisions
review-tui: add a "Find older revisions" action
review: test the catalog mirror, stray matching and backward discovery
review-tui: extract the Msgs column renderer from TrackedSeriesItem
review-tui: give the unseen badge a column of its own
review-tui: expand tracked series into per-version rows
review-tui: test per-version tracker rows

 docs/maintainer/review.rst         |   49 +
 src/b4/__init__.py                 |   60 +
 src/b4/review/_review.py           |  284 +-
 src/b4/review/tracking.py          | 2378 ++++++++++++++--
 src/b4/review_tui/_common.py       |  177 +-
 src/b4/review_tui/_lite_app.py     |    1 +
 src/b4/review_tui/_modals.py       |   15 +
 src/b4/review_tui/_review_app.py   |    2 +-
 src/b4/review_tui/_tracking_app.py | 1083 ++++++--
 src/tests/conftest.py              |   23 +
 src/tests/test___init__.py         |   62 +
 src/tests/test_review.py           |  822 ++++++
 src/tests/test_review_tracking.py  | 5256 +++++++++++++++++++++++++++++++++++-
 src/tests/test_tui_modals.py       |    1 +
 src/tests/test_tui_review.py       |  274 +-
 src/tests/test_tui_tracking.py     | 1983 +++++++++++++-
 16 files changed, 11911 insertions(+), 559 deletions(-)

---
base-commit: 362b87aa4d036884c36e4bfb9cdbdee626aba3bf
change-id: 20260718-work-b4-multiver-rows-6032fb71e951