mm/damon: fix uninitialized DAMOS field and kunit exec expectation bugs
Status from this message: [merged mm-stable] mm-damon-core-kunit-skip-wrong-region-walk-in-commit_target_regions.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mm/damon/core: initialize damos->last_appliedmm/ | +1 | 1 reply | Applied |
| 2/7 | mm/damon/core-kunit: check region count before testing in split_at()mm/ | +5 | 1 reply | Applied |
| 3/7 | mm/damon/vaddr-kunit: check region count in three_regions testmm/ | +5 | 0 replies | Applied |
| 4/7 | mm/damon/core-kunit: handle region split failure in filter_out()mm/ | +5 | 1 reply | Applied |
| 5/7 | mm/damon/core-kunit: skip wrong dest walk in commit_dests_for()mm/ | +2 | 1 reply | Applied |
| 6/7 | mm/damon/core-kunit: skip wrong quota goal walk in commit_quota_goals()mm/ | +9 | 1 reply | Applied |
| 7/7 | mm/damon/core-kunit: skip wrong region walk in commit_target_regions()mm/ | +7 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] mm/damon: fix uninitialized DAMOS field and kunit exec expectation bugs
Fix a few Sashiko-found unurgent bugs. Patch 1 fixes use of uninitialized damos->last_applied field. Patches 2-7 fix DAMON kunit tests that do invalid memory access under test failures.
The bugs are better to be fixed and eventually merged into stable@ kernel. That said, the fixes are arguably not urgent. Patch 1 only introduces negligible DAMOS efficiency degradation in occasional cases. Kunit fixes could introduce quite bad consequences but those are test code that affect only test run setups.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Drop RFC.
Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
(Was not having RFC tag on the subject by a mistake)
- Add missed region split failure check in filter_out() test.
- Rebase to latest mm-new.
SJ Park (7):
mm/damon/core: initialize damos->last_applied mm/damon/core-kunit: check region count before testing in split_at() mm/damon/vaddr-kunit: check region count in three_regions test mm/damon/core-kunit: handle region split failure in filter_out() mm/damon/core-kunit: skip wrong dest walk in commit_dests_for() mm/damon/core-kunit: skip wrong quota goal walk in
commit_quota_goals()
mm/damon/core-kunit: skip wrong region walk in commit_target_regions()
mm/damon/core.c | 1 + mm/damon/tests/core-kunit.h | 30 ++++++++++++++++++++++++++++-- mm/damon/tests/vaddr-kunit.h | 5 +++++ 3 files changed, 34 insertions(+), 2 deletions(-)
base-commit: 6bb81496f18939ccbc5f16840d5b2cf1af6c995e
Signature · 1 line
2.47.3