Skip to content

hw/display/vmware_vga: raise resolution ceiling, advertise modern capability bits

Matthew Jackson qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4hw/display/vmware_vga: raise resolution ceiling to 5K (5120x2880)hw/display/vmware_vga.c+8 -30 replies
2/4hw/display/vmware_vga: advertise PITCHLOCK capabilityhw/display/vmware_vga.c+1 -10 replies
3/4hw/display/vmware_vga: advertise EXTENDED_FIFO capabilityhw/display/vmware_vga.c+1 -10 replies
4/4hw/display/vmware_vga: advertise 8BIT_EMULATION, ALPHA_BLEND and ALPHA_CURSORhw/display/vmware_vga.c+12 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] hw/display/vmware_vga: raise resolution ceiling, advertise modern capability bits

The QEMU vmware_vga device reports SVGA_CAP_NONE when the guest reads SVGA_REG_CAPABILITIES, and caps mode validation at 2368x1770. This was historically safe because the device implements almost none of the modern VMware SVGA II feature set, but the machinery for five capability bits is in fact already present - the device just never told the guest about them.

This four-patch series fixes that. Each patch touches a single feature and is independently revertible.

| Patch | Subject |
|-------|---------|
| 1/4   | `hw/display/vmware_vga: raise resolution ceiling to 5K (5120x2880)` |
| 2/4   | `hw/display/vmware_vga: advertise PITCHLOCK capability` |
| 3/4   | `hw/display/vmware_vga: advertise EXTENDED_FIFO capability` |
| 4/4   | `hw/display/vmware_vga: advertise 8BIT_EMULATION, ALPHA_BLEND and ALPHA_CURSOR` |

## Motivation

Modern VMware SVGA II guest drivers (Linux vmwgfx, macOS 10.13+, Windows 10+) refuse to take optional fast paths when the corresponding capability bits are not advertised. The effect on macOS 15 guests in particular is:

* Cursor is monochrome and flickers (ALPHA_CURSOR missing).
* Scanout pitch does not align to guest framebuffer on non-power-of-two widths (PITCHLOCK missing).

Matthew Jackson (4):
hw/display/vmware_vga: raise resolution ceiling to 5K hw/display/vmware_vga: add PITCHLOCK capability hw/display/vmware_vga: add EXTENDED_FIFO capability hw/display/vmware_vga: add alpha-blend + alpha-cursor capability bits