Skip to content

EDAC: fsl_ddr: probe failure and remove lifetime fixes

Rosen Penev imx linux-edac lkml llvm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2EDAC: fsl_ddr: restore MC error registers on probe failuredrivers/edac/fsl_ddr_edac.c+6 -00 replies
2/2EDAC: fsl_ddr: manage mci lifetime via devres to fix remove UAFdrivers/edac/fsl_ddr_edac.c+20 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] EDAC: fsl_ddr: probe failure and remove lifetime fixes

This series fixes two lifetime/error-path issues in the FSL DDR EDAC driver (drivers/edac/fsl_ddr_edac.c):

* Patch 1: On probe failure, fsl_mc_err_probe() leaves the memory controller hardware configured to generate interrupts (DISABLE cleared, INT_EN set) while no handler is registered, which can trigger an unhandled interrupt storm on the shared IRQ line. Restore the MC error registers in both error paths.

* Patch 2: The devm-requested IRQ passes mci as context, but fsl_mc_err_remove() frees mci via edac_mc_free() before devres tears down the IRQ, leaving a use-after-free window for the shared interrupt handler. Manage mci lifetime through devres so it is freed only after the IRQ is released.

Both patches are build-tested for arm64 (defconfig + CONFIG_EDAC_FSL_DDR) with LLVM=1.

Rosen Penev (2):
EDAC: fsl_ddr: restore MC error registers on probe failure
EDAC: fsl_ddr: manage mci lifetime via devres to fix remove UAF

 drivers/edac/fsl_ddr_edac.c | 42 +++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 16 deletions(-)
Signature · 1 line
2.55.0