Skip to content

coroutine: add missing annotations

Marc-André Lureau qemu-devel xen-devel 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20260720-co-625d98c7dc5e

Versions newest first

  1. v2 Latest8 patches 2 repliesIn review
  2. v18 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- fix some annotations in patch "block: add missing coroutine annotation"
- collect trailer tags
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8monitor: annotate monitor_qmp_dispatcher_pop_any() as coroutinemonitor/qmp.c+2 -10 replies
2/8migration: fix qemu_get_counted_string annotationmigration/qemu-file.c+1 -10 replies
3/8io: add missing coroutine annotationinclude/io/channel.h io/channel.c+5 -40 replies
4/8block: add missing coroutine annotationblock/commit.c+3 -20 replies
5/8qcow2: remove invalid qcow2_check_refcounts callsblock/qcow2-snapshot.c+0 -180 replies
6/8block: add missing coroutine_fn annotationsblock/crypto.c block/io.c block/parallels.c +3 more+26 -171 reply
7/8hw/9pfs: annotate V9fsTransport callbacks as coroutine_fnhw/9pfs/9p.c hw/9pfs/9p.h hw/9pfs/virtio-9p-device.c +1 more+64 -510 replies
8/8migration/rdma: annotate and simplify wait_comp_channel()migration/rdma.c+4 -80 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMarkus ArmbrusterPeter XuKevin WolfChristian Schoenebeck
1/8R-b R-b
2/8R-b R-b
3/8R-b
4/8R-b R-b
5/8R-b
6/8
7/8A-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/8] coroutine: add missing annotations

Hi

Add missing coroutine_fn, coroutine_mixed_fn annotations and fix a few related issues across monitor, migration, io, block, and 9pfs subsystems.

---
Changes in v2:
- fix some annotations in patch "block: add missing coroutine annotation"
- collect trailer tags
- Link to v1: https://lore.kernel.org/qemu-devel/[email protected]

To: [email protected]
Cc: Markus Armbruster <[email protected]>
Cc: Peter Xu <[email protected]>
Cc: Fabiano Rosas <[email protected]>
Cc: "Daniel P. Berrangé" <[email protected]>
Cc: John Snow <[email protected]>
Cc: Vladimir Sementsov-Ogievskiy <[email protected]>
Cc: Kevin Wolf <[email protected]>
Cc: Hanna Reitz <[email protected]>
Cc: [email protected]
Cc: Stefan Hajnoczi <[email protected]>
Cc: Fam Zheng <[email protected]>
Cc: "Denis V. Lunev" <[email protected]>
Cc: Christian Schoenebeck <[email protected]>
Cc: Greg Kurz <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Anthony PERARD <[email protected]>
Cc: "Edgar E. Iglesias" <[email protected]>
Cc: [email protected]
Cc: Li Zhijian <[email protected]>

---
Marc-André Lureau (8):
monitor: annotate monitor_qmp_dispatcher_pop_any() as coroutine
migration: fix qemu_get_counted_string annotation
io: add missing coroutine annotation
block: add missing coroutine annotation
qcow2: remove invalid qcow2_check_refcounts calls
block: add missing coroutine_fn annotations
hw/9pfs: annotate V9fsTransport callbacks as coroutine_fn migration/rdma: annotate and simplify wait_comp_channel()

 hw/9pfs/9p.h                 | 26 +++++++++++++++-----------
 include/block/blockjob_int.h |  2 +-
 include/io/channel.h         |  4 ++--
 block/commit.c               |  5 +++--
 block/crypto.c               | 13 +++++++------
 block/io.c                   |  8 +++++---
 block/parallels.c            |  5 +++--
 block/qcow2-snapshot.c       | 18 ------------------
 block/qcow2.c                | 12 ++++++++----
 blockjob.c                   |  3 ++-
 hw/9pfs/9p.c                 | 31 +++++++++++++++++++------------
 hw/9pfs/virtio-9p-device.c   | 24 +++++++++++++-----------
 hw/9pfs/xen-9p-backend.c     | 34 +++++++++++++++++-----------------
 io/channel.c                 |  5 +++--
 migration/qemu-file.c        |  2 +-
 migration/rdma.c             | 12 ++++--------
 monitor/qmp.c                |  3 ++-
 17 files changed, 105 insertions(+), 102 deletions(-)

---
base-commit: 300438ffbb8d9430cac2fcc15cba6f482b2c0587
change-id: 20260720-co-625d98c7dc5e

Best regards,

Signature · 1 line
Marc-André Lureau <[email protected]>