Skip to content

This series cleans up unused module parameters from the atomisp driver.

Prajval Chaudhary linux-media linux-staging lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 2 repliesIn review
  2. v42 patches 4 repliesSuperseded
  3. v31 patch 2 repliesSuperseded

Changes in v5 from the cover letter

- Converted pad_w/pad_h to ATOMISP_PAD_* macro defines instead of global variables.
- Preserved blank line in ia_css_debug.h and sorted <linux/printk.h> header inclusion.
- Added explanation of default levels and parameter options in commit messages and cover letter.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: media: atomisp: Remove pad_w and pad_h module parametersdrivers/staging/media/atomisp/pci/atomisp_common.h drivers/staging/media/atomisp/pci/atomisp_v4l2.c+4 -80 replies
2/2staging: media: atomisp: Remove dbg_level and dbg_func module parametersdrivers/staging/media/atomisp/pci/atomisp_cmd.c drivers/staging/media/atomisp/pci/atomisp_common.h drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +4 more+18 -361 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver.

Patch 1 converts 'pad_w' and 'pad_h' module parameters into internal driver defines (ATOMISP_PAD_W and ATOMISP_PAD_H).
Patch 2 removes 'dbg_level' and 'dbg_func' module parameters and updates ia_css_debug_vdtrace() to filter trace logging to IA_CSS_DEBUG_WARNING level or below to avoid potential dmesg log flooding.

Output Behavior Difference:
- Before: Trace logging depended on setting dbg_level via module parameters. Higher values flooded dmesg with verbose low-level trace messages.
- After: Trace logging is filtered at IA_CSS_DEBUG_WARNING via standard vprintk facilities, avoiding dmesg flooding while maintaining critical warnings.

Changes in v5:
- Converted pad_w/pad_h to ATOMISP_PAD_* macro defines instead of global variables.
- Preserved blank line in ia_css_debug.h and sorted <linux/printk.h> header inclusion.
- Added explanation of default levels and parameter options in commit messages and cover letter.

Changes in v4:
- Fixed macro constant name in ia_css_debug_vdtrace() to IA_CSS_DEBUG_WARNING.
- Guarded vprintk() with level check to prevent log flooding.

Prajval Chaudhary (2):
staging: media: atomisp: Remove pad_w and pad_h module parameters
staging: media: atomisp: Remove dbg_level and dbg_func module
parameters

 drivers/staging/media/atomisp/pci/atomisp_cmd.c    |  8 ++++----
 drivers/staging/media/atomisp/pci/atomisp_common.h |  6 ++----
 .../media/atomisp/pci/atomisp_compat_css20.c       | 12 +++---------
 drivers/staging/media/atomisp/pci/atomisp_ioctl.c  |  4 ++--
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 14 --------------
 .../pci/runtime/debug/interface/ia_css_debug.h     | 10 +++++-----
 .../atomisp/pci/runtime/debug/src/ia_css_debug.c   |  4 ++--
 7 files changed, 18 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1