drm/nouveau: Fix WARN_ON() from missing blend modes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 2 repliesIn review
- v23 patches 2 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_funcdrivers/ drivers/ drivers/ +7 more | +26 | 0 replies | |
| 2/3 | drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state()drivers/ drivers/ drivers/ | +27 | 1 reply | |
| 3/3 | drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for wndwsdrivers/ | +11 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dave Airlie |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes
Recently a change went into the kernel to ensure that drivers which expose color formats which have alpha channels. This would cause nouveau to hit a WARN_ON when setting up cursors, since they do support blending
- but we never bothered trying to hook up the controls for it to nouveau.
This fixes the issue by ensuring that nouveau always exposes a blend mode for any planes with alpha channels, regardless of whether or not we have control of the blend mode hooked up. If someone wants to add control for this in the future as well, it should be fairly easy to hook up with this.
Previous version:
https://patchwork.freedesktop.org/api/1.0/series/170773/revisions/1/mbox/
Lyude Paul (3):
drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state() drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for
wndws
drivers/gpu/drm/nouveau/dispnv50/base.h | 6 ++++ drivers/gpu/drm/nouveau/dispnv50/base507c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/base827c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/base907c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/curs507a.c | 3 ++ drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++ drivers/gpu/drm/nouveau/dispnv50/wndw.c | 40 +++++++++++++++++---- drivers/gpu/drm/nouveau/dispnv50/wndw.h | 11 ++++++ drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c | 1 + 12 files changed, 64 insertions(+), 7 deletions(-)
base-commit: b0a652436b892eb9a036a031b33099dca036faaa
Signature · 1 line
2.55.0