Skip to content

drm/edid: Parse AMD VSDB FreeSync range in common code

Alex Huang amd-gfx dri-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 2 repliesSuperseded
  3. v14 patches 1 replySuperseded

Changes in v3 from the cover letter

- Parse future versions as v3 block as suggested by Mario.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/edid: Parse AMD VSDB for FreeSync refresh rangedrivers/gpu/drm/drm_edid.c include/drm/drm_connector.h+139 -300 replies
2/4drm/amd/display: Use HDMI FreeSync range from common EDID parserdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+8 -1700 replies
3/4drm/amd/display: Clean up FreeSync capability detectiondrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+38 -440 replies
4/4drm/amd/display: Remove unused DMCU/DMUB EDID CEA parserdrivers/gpu/drm/amd/display/dc/Makefile drivers/gpu/drm/amd/display/dc/dc_edid_parser.c drivers/gpu/drm/amd/display/dc/dc_edid_parser.h +3 more+0 -3270 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMario Limonciello (AMD)
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] drm/edid: Parse AMD VSDB FreeSync range in common code

This patch series implements parsing for AMD VSDB block's FreeSync related data directly in the EDID common parser.

Some monitor manufacturers advertise their VRR capability exclusively using the AMD VSDB block's FreeSync data fields, many other manufacturers (notably pre EDID 1.4 monitors and some post 1.4 monitors) also do not include the relevant continuous frequency feature flag in the EDID. This makes it difficult to differentiate true VRR capability from supporting a few refresh rates between the range specified in EDID refresh rate range field in a spec compliant manner.

Incidentally also resolves a recent regression where amdgpu failed to detect some DP monitors as VRR capable after EDID parser was moved to DRM common.

v2:
- Use a ladder style parser as suggested by Mario.
- Validate payload lengths before parsing.
- Removed an extra amd_vsdb_version reassignment.

v3:
- Parse future versions as v3 block as suggested by Mario.

Alex Huang (4):
drm/edid: Parse AMD VSDB for FreeSync refresh range drm/amd/display: Use HDMI FreeSync range from common EDID parser drm/amd/display: Clean up FreeSync capability detection drm/amd/display: Remove unused DMCU/DMUB EDID CEA parser

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 252 +++---------------
 drivers/gpu/drm/amd/display/dc/Makefile       |   1 -
 .../gpu/drm/amd/display/dc/dc_edid_parser.c   |  80 ------
 .../gpu/drm/amd/display/dc/dc_edid_parser.h   |  44 ---
 drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 121 ---------
 drivers/gpu/drm/amd/display/dc/inc/hw/dmcu.h  |  10 -
 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   |  71 -----
 drivers/gpu/drm/drm_edid.c                    | 147 ++++++++--
 include/drm/drm_connector.h                   |  22 +-
 9 files changed, 181 insertions(+), 567 deletions(-)
 delete mode 100644 drivers/gpu/drm/amd/display/dc/dc_edid_parser.c
 delete mode 100644 drivers/gpu/drm/amd/display/dc/dc_edid_parser.h
Signature · 1 line
2.34.1