Skip to content

drm/amdgpu: Support DRM format modifiers on GFX6-8 (v4)

Timur Kristóf amd-gfx dri-devel sashiko-reviews 1 version Applied

Status from this message: Applied the series. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesApplied

Changes from v1 to v2 from the cover letter

* Fix checking DRM_FORMAT_MOD_INVALID

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4drm/fourcc: Add modifiers for AMD GFX6-8include/uapi/drm/drm_fourcc.h+191 -180 replies
2/4drm/amdgpu: Convert tiling flags to modifiers on GFX6-8drivers/gpu/drm/amd/amdgpu/amdgpu_display.c+165 -120 replies
3/4drm/amd/display: Support DRM format modifiers on GFX6-8drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_plane_test.c+315 -130 replies
4/4drm/amd/display: Don't use tiling flags anymoredrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.h +1 more+2 -2082 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarek OlšákDaniel StoneAlex DeucherChristian KönigLink MauveNikola MedićDieter Nützel
1/4R-b R-b R-b A-b
2/4R-b R-b R-b A-b T-b T-b T-b
3/4R-b R-b R-b A-b T-b T-b T-b
4/4R-b R-b R-b A-b T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] drm/amdgpu: Support DRM format modifiers on GFX6-8 (v4)

GFX6-8 are the oldest GPUs supported by the amdgpu kernel driver, and the last ones that didn't support DRM format modifiers until now.

On GFX6-8, the GFX block can only use pre-determined tiling modes which are programmed by the kernel according to the tiling mode table. The new modifiers encode all the details needed for tiling on these GPUs.

For the exact details, see the commit message of:
"drm/fourcc: Add modifiers for AMD GFX6-8"

For a userspace implementation, see this Mesa MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41557
And for libdrm:
https://gitlab.freedesktop.org/mesa/libdrm/-/merge_requests/481

This series of patches are on top of amd-staging-drm-next.

Supporting DRM format modifiers on GFX6-8 will unblock many things in the Linux graphics ecosystem that previously either didn't work on these GPUs or had to implement fallbacks.
For example, compositors written in Vulkan or compositors running on Zink, interop between different APIs (eg. VAAPI / OpenGL / Vulkan) etc.

Changes from v1 to v2:

* Fix checking DRM_FORMAT_MOD_INVALID

Changes from v2 to v3:

* Return -EINVAL when pipe_config is invalid
* Log unsupported array mode with drm_dbg_kms()
* Fix block size calculation in amdgpu_display_verify_sizes()
* Add NULL check to amdgpu_dm_plane_add_modifier_dedup()
* Fix tile size calculation to bits not bytes

Changes from v3 to v4:

* Reword and clarify some comments
* Clarify check_tiling_flags_gfx6() and reject ROTATED mode
* Calculate block size in bytes not pixels

Timur Kristóf (4):
drm/fourcc: Add modifiers for AMD GFX6-8 drm/amdgpu: Convert tiling flags to modifiers on GFX6-8 drm/amd/display: Support DRM format modifiers on GFX6-8 drm/amd/display: Don't use tiling flags anymore

 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   | 177 ++++++++-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  29 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_plane.c   | 343 ++++++++++++++++--
 .../amd/display/amdgpu_dm/amdgpu_dm_plane.h   |   3 -
 .../amdgpu_dm/tests/amdgpu_dm_plane_test.c    | 147 --------
 include/uapi/drm/drm_fourcc.h                 | 209 ++++++++++-
 6 files changed, 665 insertions(+), 243 deletions(-)
Signature · 1 line
2.55.0