Skip to content

RFC smb/server: change notify support

ChenXiaoSong linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11smb/server: add debug type for change notifyfs/smb/server/glob.h fs/smb/server/server.c+3 -20 replies
2/11smb/server: validate notify requestsfs/smb/server/Makefile fs/smb/server/notify.c fs/smb/server/notify.h +1 more+138 -61 reply
3/11smb/server: support canceling notify requestsfs/smb/server/notify.c+99 -40 replies
4/11smb/server: watch directories for changesfs/smb/server/Kconfig fs/smb/server/notify.c+227 -21 reply
5/11smb/server: keep notify watches on file handlesfs/smb/server/notify.c fs/smb/server/notify.h fs/smb/server/vfs_cache.c +1 more+52 -41 reply
6/11smb/server: save simple notify eventsfs/smb/server/notify.c+106 -00 replies
7/11smb/server: save old names for rename notify eventsfs/smb/server/notify.c+78 -00 replies
8/11smb/server: match rename notify eventsfs/smb/server/notify.c+67 -40 replies
9/11smb/server: encode notify eventsfs/smb/server/notify.c+99 -00 replies
10/11smb/server: send notify events to the clientfs/smb/server/notify.c+171 -03 replies
11/11smb/server: break directory leases before sending notify eventsfs/smb/server/notify.c fs/smb/server/oplock.c fs/smb/server/oplock.h+72 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/11] smb/server: change notify support

From: ChenXiaoSong <[email protected]>

Sorry for taking such a long time to complete the ksmbd change notify feature. Over the past few months, I have been busy with the birth of my daughter and my PhD-related tasks, which left me with limited time to work on it.

Once Gaël updates his patch ("ksmbd: defer CHANGE_NOTIFY completion instead of STATUS_NOT_IMPLEMENTED"), I will rebase my patchset on top of it.

To test this feature, the following patches need to be applied to cifs-utils and kernel smb client:
- cifs-utils: https://chenxiaosong.com/lkml/cifs-utils-parse-notify
- kernel smb client: https://chenxiaosong.com/lkml/cifs-improve-notify

The complete kernel client and server patches are also available at the following link:
https://chenxiaosong.com/repo/linux/ksmbd-change-notify

ChenXiaoSong (11):
smb/server: add debug type for change notify smb/server: validate notify requests
smb/server: support canceling notify requests smb/server: watch directories for changes
smb/server: keep notify watches on file handles smb/server: save simple notify events
smb/server: save old names for rename notify events smb/server: match rename notify events
smb/server: encode notify events
smb/server: send notify events to the client smb/server: break directory leases before sending notify events

 fs/smb/server/Kconfig     |    1 +
 fs/smb/server/Makefile    |    2 +-
 fs/smb/server/glob.h      |    3 +-
 fs/smb/server/notify.c    | 1011 +++++++++++++++++++++++++++++++++++++
 fs/smb/server/notify.h    |   24 +
 fs/smb/server/oplock.c    |   40 ++
 fs/smb/server/oplock.h    |    1 +
 fs/smb/server/server.c    |    2 +-
 fs/smb/server/smb2pdu.c   |   12 +-
 fs/smb/server/vfs_cache.c |    3 +
 fs/smb/server/vfs_cache.h |    4 +
 11 files changed, 1095 insertions(+), 8 deletions(-)
 create mode 100644 fs/smb/server/notify.c
 create mode 100644 fs/smb/server/notify.h
Signature · 1 line
2.54.0