FlexCAN fixes for-11.1
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | hw/net/can/flexcan: Use mbs[] array for FIFO pophw/ | +5 | 1 reply | |
| 2/9 | hw/net/flexcan: Drop unused RX FIFO register overlayinclude/ | +0 | 1 reply | |
| 3/9 | hw/net/can/flexcan: Fix out-of-bounds access in flexcan_mx_rx()hw/ | +1 | 1 reply | |
| 4/9 | hw/net/can/flexcan: Fix mailbox index calculation in flexcan_mem_write()hw/ | +3 | 1 reply | |
| 5/9 | hw/net/can/flexcan: Fix mailbox index calculation in flexcan_mem_read()hw/ | +3 | 1 reply | |
| 6/9 | hw/net/can/flexcan: Fix mailbox reset mask initializationhw/ | +5 | 1 reply | |
| 7/9 | hw/net/flexcan: Drop oversized 'mb[]' mailbox viewinclude/ | +2 | 6 replies | |
| 8/9 | hw/net/can/flexcan: Fix RXIMR reset maskhw/ | +1 | 1 reply | |
| 9/9 | hw/net/can/flexcan: Remove RX SMB raw viewhw/ include/ | +11 | 1 reply |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Pavel Pisa | Peter Maydell |
|---|---|---|---|
| Series | T-b | ||
| 1/9 | R-b | ||
| 2/9 | R-b | ||
| 3/9 | R-b | ||
| 4/9 | R-b | ||
| 5/9 | R-b | ||
| 6/9 | R-b | ||
| 7/9 | R-b | ||
| 8/9 | R-b | ||
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/9] FlexCAN fixes for-11.1
This series attempts to fix the Coveriy issues pointed out by Peter in the FlexCAN emulation [1]. In addition, it fixes some reset masks to preserve register contents across resets as intended. It also fixes some register offsets due to a union being inadvertantly too large; this would affect migration if addressed after the release. Last but not least it eliminates an unneeded union.
Testing done:
* make check
* Run cangen and candump on the host and guest in both directions
Bernhard Beschow (9):
hw/net/can/flexcan: Use mbs[] array for FIFO pop hw/net/flexcan: Drop unused RX FIFO register overlay hw/net/can/flexcan: Fix out-of-bounds access in flexcan_mx_rx() hw/net/can/flexcan: Fix mailbox index calculation in
flexcan_mem_write()
hw/net/can/flexcan: Fix mailbox index calculation in
flexcan_mem_read()
hw/net/can/flexcan: Fix mailbox reset mask initialization hw/net/flexcan: Drop oversized 'mb[]' mailbox view hw/net/can/flexcan: Fix RXIMR reset mask hw/net/can/flexcan: Remove RX SMB raw view
include/hw/net/flexcan.h | 22 +++---------------- hw/net/can/flexcan.c | 47 ++++++++++++++++++++++++---------------- 2 files changed, 31 insertions(+), 38 deletions(-)
Signature · 1 line
2.55.0