Skip to content

FlexCAN fixes for-11.1

Bernhard Beschow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/net/can/flexcan: Use mbs[] array for FIFO pophw/net/can/flexcan.c+5 -51 reply
2/9hw/net/flexcan: Drop unused RX FIFO register overlayinclude/hw/net/flexcan.h+0 -111 reply
3/9hw/net/can/flexcan: Fix out-of-bounds access in flexcan_mx_rx()hw/net/can/flexcan.c+1 -11 reply
4/9hw/net/can/flexcan: Fix mailbox index calculation in flexcan_mem_write()hw/net/can/flexcan.c+3 -41 reply
5/9hw/net/can/flexcan: Fix mailbox index calculation in flexcan_mem_read()hw/net/can/flexcan.c+3 -51 reply
6/9hw/net/can/flexcan: Fix mailbox reset mask initializationhw/net/can/flexcan.c+5 -11 reply
7/9hw/net/flexcan: Drop oversized 'mb[]' mailbox viewinclude/hw/net/flexcan.h+2 -46 replies
8/9hw/net/can/flexcan: Fix RXIMR reset maskhw/net/can/flexcan.c+1 -11 reply
9/9hw/net/can/flexcan: Remove RX SMB raw viewhw/net/can/flexcan.c include/hw/net/flexcan.h+11 -61 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéPavel PisaPeter Maydell
SeriesT-b
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] FlexCAN fixes for-11.1

This series attempts to fix the Coveriy issues pointed out by Peter in the FlexCAN emulation [1]. In addition, it fixes some reset masks to preserve register contents across resets as intended. It also fixes some register offsets due to a union being inadvertantly too large; this would affect migration if addressed after the release. Last but not least it eliminates an unneeded union.

Testing done:
* make check
* Run cangen and candump on the host and guest in both directions

[1] https://lore.kernel.org/qemu-devel/CAFEAcA-QBiPfgN4YJXD9FQULobpBVNgeJHSqG7Eqg1CzyKTfaA@mail.gmail.com/

Bernhard Beschow (9):
hw/net/can/flexcan: Use mbs[] array for FIFO pop hw/net/flexcan: Drop unused RX FIFO register overlay hw/net/can/flexcan: Fix out-of-bounds access in flexcan_mx_rx() hw/net/can/flexcan: Fix mailbox index calculation in
flexcan_mem_write()
hw/net/can/flexcan: Fix mailbox index calculation in
flexcan_mem_read()
hw/net/can/flexcan: Fix mailbox reset mask initialization hw/net/flexcan: Drop oversized 'mb[]' mailbox view hw/net/can/flexcan: Fix RXIMR reset mask hw/net/can/flexcan: Remove RX SMB raw view

 include/hw/net/flexcan.h | 22 +++----------------
 hw/net/can/flexcan.c     | 47 ++++++++++++++++++++++++----------------
 2 files changed, 31 insertions(+), 38 deletions(-)
Signature · 1 line
2.55.0