Skip to content

media: ov8856: run full power sequence on ACPI

Serin Yeh linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 5 repliesIn review
  2. v32 patches 3 repliesSuperseded

Changes in v4 from the cover letter

[1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism
- Modified commit log description.
- Added tags : Reviewed-by
[2/2] media: i2c: ov8856: fix debug message to report actual CSI-2 lane
count
- No change

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: i2c: ov8856 : remove ACPI node bypass mechanismdrivers/media/i2c/ov8856.c+10 -195 replies
2/2media: i2c: ov8856: fix debug message to report actual CSI-2 lane countdrivers/media/i2c/ov8856.c+2 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBryan O'DonoghueKieran Bingham
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] media: ov8856: run full power sequence on ACPI

This series makes the ov8856 driver request its power resources and run the power on/off sequence on ACPI platforms as well as DT, and fixes an unrelated debug message.

- Background: power resources on Intel ACPI platforms :
On Intel platforms the sensor is enumerated via ACPI, and an INT3472 "discrete" companion device (the power-logic-control driver under drivers/platform/x86/intel/int3472) registers the sensor's reset/powerdown GPIOs and the regulator supply.
These resources are therefore discoverable and usable through the standard gpiod/regulator lookups at probe time.

- Current symptom :
Previously the driver guarded both the GPIO/regulator acquisition in ov8856_get_hwcfg() and the whole power on/off sequence with is_acpi_node() and skipped them on ACPI. As a result the sensor was never powered or reset by the driver and probe failed when reading the chip ID in ov8856_identify_module().
Removing those checks makes the ACPI path behave like DT.

- Validation :
Tested on Intel platforms with kernel 6.17 and 7.0.

Changes in v4:
[1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism
- Modified commit log description.
- Added tags : Reviewed-by
[2/2] media: i2c: ov8856: fix debug message to report actual CSI-2 lane
count
- No change

Changes in v3:
Add cover letter to describe details of patches.
[1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism
- Add tags : Fixes and Cc
- Removed a sentence from commit as this change has already been split out and is covered separately in patch 2/2
[2/2] media: i2c: ov8856: fix debug message to report actual CSI-2 lane
count
- Added tags : Cc

Changes in v2:
[1/2] media: i2c: ov8856 : remove ACPI node bypass mechanism
- No change
[2/2] media: i2c: ov8856: fix debug message to report actual CSI-2 lane
count
- Added tags : Fixes and Reviewed-by

Serin Yeh (2):
media: i2c: ov8856 : remove ACPI node bypass mechanism
media: i2c: ov8856: fix debug message to report actual CSI-2 lane
count

 drivers/media/i2c/ov8856.c | 32 ++++++++++++--------------------
 1 file changed, 12 insertions(+), 20 deletions(-)
Signature · 1 line
2.25.1