Skip to content

ipset test updates

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tests: check_extensions: introduce and use IPSET_MACHINE_SLOWtests/check_extensions+19 -40 replies
2/5tests: hash:net.t: prefer tail -ntests/hash:net.t+1 -10 replies
3/5tests: prefer diff -u to cmptests/iphash.t tests/restore.t+5 -50 replies
4/5tests: hash:net,iface.t: add reproducer for UaFtests/hash:net,iface.t+5 -00 replies
5/5tests: match_target.t check for proper cidr matchingtests/match_target.t+13 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH ipset 0/5] ipset test updates

These are extensions to existing test cases, no tests are disabled and all tests are expected to pass regardless if the rhashtable patch set is applied or not.

1) Introduce IPSET_MACHINE_SLOW to prevent ipset test timeouts on slow machines. Increase the slack value to 30s when this flag is set.

2) Prefer tail -n in hash:net.t tests to avoid Fedora 44 error.

3) Use diff -u instead of cmp in tests to improve error readability.

4) Add a UaF reproducer to hash:net,iface.t. Verify that deleting non-existing elements fails without triggering an incorrect free.

5) Add a test for CIDR matching with the "multi" flag in match_target.t.

Florian Westphal (5):
tests: check_extensions: introduce and use IPSET_MACHINE_SLOW
tests: hash:net.t: prefer tail -n
tests: prefer diff -u to cmp
tests: hash:net,iface.t: add reproducer for UaF
tests: match_target.t check for proper cidr matching

 tests/check_extensions | 23 +++++++++++++++++++----
 tests/hash:net,iface.t |  5 +++++
 tests/hash:net.t       |  2 +-
 tests/iphash.t         |  8 ++++----
 tests/match_target.t   | 14 +++++++++++++-
 tests/restore.t        |  2 +-
 6 files changed, 43 insertions(+), 11 deletions(-)
Signature · 1 line
2.54.0