vxlan: fixes for skb header pulling, cloning, and concurrency in TX path
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | vxlan: re-fetch eth header after route_shortcircuit()drivers/ | +1 | 1 reply | Applied |
| 2/5 | vxlan: unclone skb head before modifying eth header in route_shortcircuit()drivers/ | +4 | 0 replies | Applied |
| 3/5 | vxlan: use neigh_ha_snapshot() in route_shortcircuit()drivers/ | +4 | 1 reply | Applied |
| 4/5 | vxlan: use pskb_network_may_pull() in route_shortcircuit()drivers/ | +2 | 1 reply | Applied |
| 5/5 | vxlan: use pskb_network_may_pull() for transmit path header pullsdrivers/ drivers/ | +5 | 2 replies | Applied |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Vadim Fedorenko | Ido Schimmel |
|---|---|---|
| 1/5 | R-b | |
| 2/5 | ||
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/5] vxlan: fixes for skb header pulling, cloning, and concurrency in TX path
While working on RTNL-less fill_info for vxlan, Sashiko found annoying pre-existing issues, adding noise to an already complex work.
This series addresses some of them in VXLAN transmit path, primarily within route_shortcircuit(), header validation, and neighbour lookup.
Patch 1 fixes a potential use-after-free in vxlan_xmit() caused by caching the Ethernet header pointer ('eth') before calling route_shortcircuit(), which can reallocate skb->head via pskb_may_pull().
Patch 2 calls skb_cow_head() in route_shortcircuit() before modifying the Ethernet header in-place, preventing packet header corruption when the skb is cloned (e.g., by packet sockets, tcpdump, or dev_queue_xmit).
Patch 3 replaces direct reads of n->ha in route_shortcircuit() with neigh_ha_snapshot() to safely snapshot the neighbour hardware address under seqlock protection, avoiding potential torn reads during asynchronous updates.
Patch 4 changes route_shortcircuit() to use pskb_network_may_pull() instead of pskb_may_pull(). Since skb->data points to the MAC header on transmit (skb_network_offset(skb) == ETH_HLEN), pskb_may_pull() was only checking 6 bytes into the IP header, leaving the remainder un-pulled in non-linear frags.
Patch 5 applies pskb_network_may_pull() to the remaining transmit-path header pull checks in arp_reduce(), ND solicitation proxy checks, and MDB entry lookup, where skb->data similarly points to the Ethernet header.
Eric Dumazet (5):
vxlan: re-fetch eth header after route_shortcircuit()
vxlan: unclone skb head before modifying eth header in
route_shortcircuit()
vxlan: use neigh_ha_snapshot() in route_shortcircuit()
vxlan: use pskb_network_may_pull() in route_shortcircuit()
vxlan: use pskb_network_may_pull() for transmit path header pulls
drivers/net/vxlan/vxlan_core.c | 21 ++++++++++++++------- drivers/net/vxlan/vxlan_mdb.c | 4 ++-- 2 files changed, 16 insertions(+), 9 deletions(-)
Signature · 1 line
2.55.0.229.g6434b31f56-goog