Skip to content

RFC Drop vhost async (DMA-accelerated) datapath

David Marchand dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3examples: stop using vhost async datapathexamples/vhost/Makefile examples/vhost/main.c examples/vhost/main.h +4 more+13 -4531 reply
2/3vhost: refuse async datapathdoc/guides/prog_guide/vhost_lib.rst doc/guides/rel_notes/release_26_11.rst lib/vhost/rte_vhost.h +2 more+17 -2440 replies
3/3vhost: drop async datapathdoc/guides/prog_guide/vhost_lib.rst doc/guides/rel_notes/release_26_11.rst lib/vhost/meson.build +6 more+679 -35970 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime Coquelin
SeriesR-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/3] Drop vhost async (DMA-accelerated) datapath

The integration of this feature in OVS has been postponed following feedback how the current API forced the complexity on the application side. There is no contributor working on making those changes.

The feature has no other identified opensource consumer.

On the other hand, this feature has been left unattended for some years now while the "normal" datapath is actively maintained.
It is highly likely the async datapath code, which never underwent a stabilisation phase, is riddled with bugs.

Given the craziness around finding security bugs with AI, and since the vhost library is a good target, I propose to drop this feature and reduce the library attack surface.

Signature · 29 lines
David Marchand

David Marchand (3):
  examples: stop using vhost async datapath
  vhost: refuse async datapath
  vhost: drop async datapath

 doc/guides/prog_guide/vhost_lib.rst    |  151 +-
 doc/guides/rel_notes/release_26_11.rst |   20 +
 examples/vhost/Makefile                |    2 -
 examples/vhost/main.c                  |  436 +---
 examples/vhost/main.h                  |   21 +-
 examples/vhost/meson.build             |    2 -
 examples/vhost_crypto/Makefile         |    1 -
 examples/vhost_crypto/main.c           |    3 +-
 examples/vhost_crypto/meson.build      |    1 -
 lib/vhost/meson.build                  |    3 +-
 lib/vhost/rte_vhost.h                  |    2 +-
 lib/vhost/rte_vhost_async.h            |  293 ---
 lib/vhost/socket.c                     |   27 +-
 lib/vhost/vhost.c                      |  434 ----
 lib/vhost/vhost.h                      |  115 -
 lib/vhost/vhost_user.c                 |  215 +-
 lib/vhost/virtio_net.c                 | 3275 +++++-------------------
 17 files changed, 708 insertions(+), 4293 deletions(-)
 delete mode 100644 lib/vhost/rte_vhost_async.h

-- 
2.54.0