Skip to content

notifier: add device-managed registration APIs and convert drivers

Eliav Farber acpica-devel linux-acpi linux-gpio linux-iio linux-input linux-pwm lkml platform-driver-x86 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest13 patches 14 repliesApplied
  2. v413 patches 15 repliesSuperseded
  3. v312 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches0 repliesSuperseded
v112 patches12 repliesSuperseded

Changes in v5 from the cover letter

- Patch 1: rename notifier_block parameter from 'n' to 'nb' to match the devres struct field name (Uwe Kleine-König)
- Patch 2: remove extra blank line left after deleting the unregister callback (Uwe Kleine-König)

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/13notifier: add device-managed registration APIsinclude/linux/notifier.h kernel/notifier.c+110 -05 replies
2/13pwm: iqs620a: use devm_blocking_notifier_chain_register()drivers/pwm/pwm-iqs620a.c+3 -201 reply
3/13iio: light: iqs621-als: use devm_blocking_notifier_chain_register()drivers/iio/light/iqs621-als.c+3 -211 reply
4/13iio: position: iqs624: use devm_blocking_notifier_chain_register()drivers/iio/position/iqs624-pos.c+3 -211 reply
5/13gpio: adp5585: use devm_blocking_notifier_chain_register()drivers/gpio/gpio-adp5585.c+3 -171 reply
6/13platform/x86: bitland-mifs-wmi: use devm_blocking_notifier_chain_register()drivers/platform/x86/bitland-mifs-wmi.c+3 -140 replies
7/13Input: adp5585: use devm_blocking_notifier_chain_register()drivers/input/keyboard/adp5585-keys.c+3 -150 replies
8/13ACPI: APEI: GHES: remove unused ghes_{,un}register_vendor_record_notifier()drivers/acpi/apei/ghes.c include/acpi/ghes.h+3 -290 replies
9/13ACPI: APEI: GHES: use devm_blocking_notifier_chain_register()drivers/acpi/apei/ghes.c+3 -140 replies
10/13platform/x86: uniwill-wmi: use devm_blocking_notifier_chain_register()drivers/platform/x86/uniwill/uniwill-wmi.c+3 -140 replies
11/13gpio: eic-sprd: use devm_atomic_notifier_chain_register()drivers/gpio/gpio-eic-sprd.c+2 -151 reply
12/13gpio: gpiolib-kunit: use devm_blocking_notifier_chain_register()drivers/gpio/gpiolib-kunit.c+2 -121 reply
13/13reboot: use devm_blocking_notifier_chain_register()kernel/reboot.c+2 -220 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronBartosz GolaszewskiDmitry TorokhovArmin WolfBaolin WangBradley MorganLinus Walleij
1/13T-b A-b A-b
2/13
3/13A-b
4/13A-b
5/13A-b R-b
6/13
7/13A-b
8/13R-b
9/13R-b
10/13R-b
11/13A-b R-b R-b
12/13A-b R-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/13] notifier: add device-managed registration APIs and convert drivers

Many drivers repeat the same boilerplate when registering notifiers with device lifetime:

1. Register the notifier with *_notifier_chain_register()
2. Check for error
3. Register a devm action to unregister on teardown
4. Implement a per-driver static unregister callback

This series adds devm_atomic_notifier_chain_register() and devm_blocking_notifier_chain_register() that automatically unregister the notifier when the device is unbound, then converts 11 drivers to use them.

Each conversion eliminates a per-driver unregister callback and the associated devm_add_action_or_reset() call, reducing code by ~15 lines per driver.

The implementation follows the established devres pattern used by other device-managed kernel APIs.

Changes in v5:
- Patch 1: rename notifier_block parameter from 'n' to 'nb' to match the devres struct field name (Uwe Kleine-König)
- Patch 2: remove extra blank line left after deleting the unregister callback (Uwe Kleine-König)

Changes in v4:
- Patch 8: split the removal of unused ghes_register_vendor_record_notifier() and ghes_unregister_vendor_record_notifier() into a separate preceding patch (Andy Shevchenko)

Changes in v3:
- Patch 1: drop devm_raw_notifier_chain_register() since raw notifiers require caller-provided locking which is incompatible with the devres teardown callback (Sashiko)
- Patch 12: fix commit message to accurately describe the old code as using devres_alloc() + register_reboot_notifier() (Sashiko)

Changes in v2:
- Patch 1: drop 'extern' from new function prototypes (Bart Van Assche)
- Patch 1: fix kerneldoc to use 'Return:' format (Bart Van Assche)
- Patch 1: use <linux/device/devres.h> instead of <linux/device.h> (Andy Shevchenko)
- Patch 8: also remove unused ghes_register_vendor_record_notifier() and ghes_unregister_vendor_record_notifier() along with their exports and ghes.h declarations (Jonathan Cameron)

Eliav Farber (13):
notifier: add device-managed registration APIs
pwm: iqs620a: use devm_blocking_notifier_chain_register()
iio: light: iqs621-als: use devm_blocking_notifier_chain_register()
iio: position: iqs624: use devm_blocking_notifier_chain_register()
gpio: adp5585: use devm_blocking_notifier_chain_register() platform/x86: bitland-mifs-wmi: use
devm_blocking_notifier_chain_register()
Input: adp5585: use devm_blocking_notifier_chain_register()
ACPI: APEI: GHES: remove unused
ghes_{,un}register_vendor_record_notifier()
ACPI: APEI: GHES: use devm_blocking_notifier_chain_register() platform/x86: uniwill-wmi: use devm_blocking_notifier_chain_register()
gpio: eic-sprd: use devm_atomic_notifier_chain_register()
gpio: gpiolib-kunit: use devm_blocking_notifier_chain_register()
reboot: use devm_blocking_notifier_chain_register()

 drivers/acpi/apei/ghes.c                   |  27 +-----
 drivers/gpio/gpio-adp5585.c                |  20 +---
 drivers/gpio/gpio-eic-sprd.c               |  17 +---
 drivers/gpio/gpiolib-kunit.c               |  14 +--
 drivers/iio/light/iqs621-als.c             |  24 +----
 drivers/iio/position/iqs624-pos.c          |  24 +----
 drivers/input/keyboard/adp5585-keys.c      |  18 +---
 drivers/platform/x86/bitland-mifs-wmi.c    |  17 +---
 drivers/platform/x86/uniwill/uniwill-wmi.c |  17 +---
 drivers/pwm/pwm-iqs620a.c                  |  23 +----
 include/acpi/ghes.h                        |  16 ----
 include/linux/notifier.h                   |   7 ++
 kernel/notifier.c                          | 103 +++++++++++++++++++++
 kernel/reboot.c                            |  24 +----
 14 files changed, 140 insertions(+), 211 deletions(-)
Signature · 1 line
2.47.3