Skip to content

mm: add basic PTE const type-safety

Pedro Falcato linux-arm-kernel linux-fsdevel linux-mm linux-parisc linuxppc-dev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 26 repliesIn review
  2. v15 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Small fixups on the arm64 side
- Re-order patches in a way such that bisection is preserved
- Pick up Helge's patch dropping parisc ptep_get()
- Constify s390's ptep_get() as well

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mm/arm64: constify pte_get*() and contpte get logicarch/arm64/include/asm/pgtable.h arch/arm64/mm/contpte.c+13 -83 replies
2/6parisc: Drop own implementations for ptep_get() and ptep_test_and_clear_young()arch/parisc/include/asm/pgtable.h+0 -205 replies
3/6mm/powerpc/8xx: constify ptep_get() argumentarch/powerpc/include/asm/nohash/32/pte-8xx.h+1 -17 replies
4/6mm/s390: constify ptep_get() argumentarch/s390/include/asm/pgtable.h+1 -11 reply
5/6mm: constify generic pte_get*()include/linux/pgtable.h+3 -32 replies
6/6mm: constify the pte_offset_map_ro_nolock() return valuearch/powerpc/mm/pgtable.c include/linux/mm.h include/linux/pgtable.h +3 more+8 -84 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMuhammad Usama AnjumChristophe Leroy (CS GROUP)Lorenzo Stoakes (ARM)David Hildenbrand (Arm)
SeriesR-b R-b
1/6
2/6R-b
3/6R-b
4/6R-b
5/6R-b A-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] mm: add basic PTE const type-safety

Since forever, MM code has thrown pte_t * around with no concern for const safety, or typesafety of any kind. This is confusing. Attempt to address it by:
1) Making sure pte_get*() helpers can cope with const pte_t * arguments
2) Constifying the pte_offset_map_ro_nolock() return type, which by definition already pledges that users will not write to it.

These two simple steps were already able to uncover code smell from khugepaged + do_swap_page().

Separate steps could include introducing pte_offset_map_ro_lock() for more widespread usage of this.

Benefits of this include less confusion and better type-safety. It could also futurely aid in efforts such as [0] which may want semantic annotation of these accesses.

Based on mm-unstable and compile-tested on a handful of architectures.

No functional changes intended.

[CC list editorially trimmed for brevity reasons; apologies if you're not on it]

Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc "James E.J. Bottomley" <[email protected]>
Cc Helge Deller <[email protected]>
Cc Madhavan Srinivasan <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc "Liam R. Howlett" <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Michal Hocko <[email protected]>
Cc "Matthew Wilcox (Oracle)" <[email protected]>
Cc Jan Kara <[email protected]>
Cc Zi Yan <[email protected]>
Cc Baolin Wang <[email protected]>
Cc Nico Pache <[email protected]>
Cc Ryan Roberts <[email protected]>
Cc Dev Jain <[email protected]>
Cc Barry Song <[email protected]>
Cc Lance Yang <[email protected]>
Cc Usama Arif <[email protected]>
Cc Kevin Brodsky <[email protected]>
Cc Muhammad Usama Anjum <[email protected]>

v2:
- Small fixups on the arm64 side
- Re-order patches in a way such that bisection is preserved
- Pick up Helge's patch dropping parisc ptep_get()
- Constify s390's ptep_get() as well

Helge Deller (1):
parisc: Drop own implementations for ptep_get() and
ptep_test_and_clear_young()

Pedro Falcato (5):
mm/arm64: constify pte_get*() and contpte get logic mm/powerpc/8xx: constify ptep_get() argument mm/s390: constify ptep_get() argument
mm: constify generic pte_get*()
mm: constify the pte_offset_map_ro_nolock() return value

 arch/arm64/include/asm/pgtable.h             | 10 +++++-----
 arch/arm64/mm/contpte.c                      | 11 ++++++++---
 arch/parisc/include/asm/pgtable.h            | 20 --------------------
 arch/powerpc/include/asm/nohash/32/pte-8xx.h |  2 +-
 arch/powerpc/mm/pgtable.c                    |  2 +-
 arch/s390/include/asm/pgtable.h              |  2 +-
 include/linux/mm.h                           |  4 ++--
 include/linux/pgtable.h                      |  8 ++++----
 mm/filemap.c                                 |  2 +-
 mm/khugepaged.c                              |  2 +-
 mm/pgtable-generic.c                         |  4 ++--
 11 files changed, 26 insertions(+), 41 deletions(-)
Signature · 1 line
2.55.0