Skip to content

hw/[block]: Fix missing accounting

Hanna Czenczek qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/virtio-blk: Account discard operationshw/block/virtio-blk.c+11 -150 replies
2/6hw/virtio-blk: Complete zone-append cookieshw/block/virtio-blk.c+7 -10 replies
3/6hw/nvme: Fix block accounting in nvme_copy()hw/nvme/ctrl.c+33 -201 reply
4/6hw/nvme: Fix block accounting for comparehw/nvme/ctrl.c+12 -53 replies
5/6hw/ide: Have ide_dma_cb() complete accountinghw/ide/core.c+2 -10 replies
6/6hw/scsi-disk: Fix accounting for IGNORE, ret > 0hw/scsi/scsi-disk.c+7 -00 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéKlaus JensenStefan Hajnoczi
SeriesR-b
1/6
2/6
3/6R-b
4/6R-b R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] hw/[block]: Fix missing accounting

Hi,

There are some places where block accounting should be happening, but is not; either because the whole operation is not accounted (like discard operations in virtio-blk) or because certain code paths forget to finalize existing cookies.

Hanna Czenczek (6):
hw/virtio-blk: Account discard operations hw/virtio-blk: Complete zone-append cookies hw/nvme: Fix block accounting in nvme_copy() hw/nvme: Fix block accounting for compare hw/ide: Have ide_dma_cb() complete accounting hw/scsi-disk: Fix accounting for IGNORE, ret > 0

 hw/block/virtio-blk.c | 34 +++++++++++----------
 hw/ide/core.c         |  3 +-
 hw/nvme/ctrl.c        | 70 +++++++++++++++++++++++++++----------------
 hw/scsi/scsi-disk.c   |  7 +++++
 4 files changed, 72 insertions(+), 42 deletions(-)
Signature · 1 line
2.55.0