Skip to content

RDMA/efa: Add support for 128B admin v2 SQ entry

Yonatan Nachum linux-rdma 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Changes in v3 from the cover letter

* Ensure proper alignment of stack admin buffer to prevent unaligned memory accesses.
v2: https://lore.kernel.org/all/[email protected]/
* Rebase on for-next branch instead of wip/leon-for-next.
v1: https://lore.kernel.org/all/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3RDMA/efa: Decouple admin command payload from admin headerdrivers/infiniband/hw/efa/efa_admin_cmds_defs.h drivers/infiniband/hw/efa/efa_admin_defs.h drivers/infiniband/hw/efa/efa_com.c +2 more+112 -2420 replies
2/3RDMA/efa: Generalize the admin SQdrivers/infiniband/hw/efa/efa_com.c drivers/infiniband/hw/efa/efa_com.h+24 -270 replies
3/3RDMA/efa: Add support for 128B admin v2 SQ entrydrivers/infiniband/hw/efa/efa_admin_defs.h drivers/infiniband/hw/efa/efa_com.c drivers/infiniband/hw/efa/efa_com.h+116 -320 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel KranzdorfMichael MargolinTom SelaJason Gunthorpe
SeriesR-b
1/3R-b R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH for-next v3 0/3] RDMA/efa: Add support for 128B admin v2 SQ entry

Changelog:
v3:
* Ensure proper alignment of stack admin buffer to prevent unaligned memory accesses.
v2: https://lore.kernel.org/all/[email protected]/
* Rebase on for-next branch instead of wip/leon-for-next.
v1: https://lore.kernel.org/all/[email protected]/

-------------------------------------------------------------------------
Add support for the new 128-byte admin v2 SQ entry format. The v2 entry extends the v1 header with checksum and payload version fields, and carries a larger inline payload.

The series first decouples admin command payloads from admin headers, then generalizes the SQ ring to use a configurable entry size, and finally adds the v2 entry format selection based on device API version.

Yonatan Nachum (3):
RDMA/efa: Decouple admin command payload from admin header RDMA/efa: Generalize the admin SQ
RDMA/efa: Add support for 128B admin v2 SQ entry

 .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 116 +++--------
 drivers/infiniband/hw/efa/efa_admin_defs.h    |  33 ++-
 drivers/infiniband/hw/efa/efa_com.c           | 194 +++++++++++-------
 drivers/infiniband/hw/efa/efa_com.h           |  16 +-
 drivers/infiniband/hw/efa/efa_com_cmd.c       | 170 +++++----------
 5 files changed, 240 insertions(+), 289 deletions(-)
Signature · 1 line
2.50.1