Skip to content

arm64: dts: amlogic: add support for Orbbec Zora P1

Alberto Robazza linux-amlogic linux-arm-kernel linux-devicetree lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v43 patches 2 repliesSuperseded
  3. v33 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches1 replySuperseded
v13 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Add Krzysztof Kozlowski's Acked-by on patch 1/3 (given during v3 review, was accidentally dropped in v4).

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: vendor-prefixes: add OrbbecDocumentation/devicetree/bindings/vendor-prefixes.yaml+2 -00 replies
2/3dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatibleDocumentation/devicetree/bindings/arm/amlogic.yaml+1 -01 reply
3/3arm64: dts: amlogic: add support for Orbbec Zora P1arch/arm64/boot/dts/amlogic/Makefile arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts+106 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] arm64: dts: amlogic: add support for Orbbec Zora P1

The Orbbec Zora P1 is a vision development board based on the Amlogic A311D (Meson G12B) SoC, with 2 or 4 GiB LPDDR4, an Ampak AP6256 combo module (Broadcom BCM43456 Wi-Fi over SDIO and BCM4345C5 Bluetooth over UART_A), HDMI output and Gigabit Ethernet.

According to its specifications and original device tree, the board is a revised version of the ODROID-N2 with Wi-Fi, Bluetooth and an Amlogic A311D instead of the original S922X. The device tree therefore builds on meson-g12b-a311d.dtsi and meson-g12b-odroid-n2.dtsi, mirroring meson-g12b-odroid-n2-plus.dts. It extends those descriptions with the board-specific AP6256 wiring. The status LED is green instead of the original ODROID-N2 blue and has inverted polarity.

This series consists of:
Patch 1: add the "orbbec" vendor prefix.
Patch 2: document the "orbbec,zora-p1" board compatible. Patch 3: add the meson-g12b-zora-p1.dts board file and Makefile entry.

The DTB was built, validated against the amlogic.yaml binding using DT_SCHEMA_FILES, and boot-tested twice on the board. The AP6256 Wi-Fi interface enumerates and operates with the GPIOX_16 reset and PWM clock description present. Removing the wifi32k and pwm_ef descriptions causes the SDIO Wi-Fi device to stop working on this board.

---
Changes in v2:
- Investigated the apparent GPIOX_16 overlap between the SDIO power sequence reset and the 32.768 kHz PWM clock. Retained the description after two successful hardware tests; removing the clock description prevents the AP6256 Wi-Fi device from working.
- Sort the new DTB entry alphabetically in the Amlogic Makefile.
- Sort the "orbbec" entry alphabetically in vendor-prefixes.yaml.

---
Changes in v3:
- Polished meson-g12b-zora-p1.dts.
- Use proper comment with /* and */.
- Use the new bindings with function and color properties instead of label in leds node.
- Include dt-bindings/leds/common.h.

---
Changes in v4:
- Dropped unnecessary sentences from patch 1 and 2.
- Renamed "wifi32k" node to "clock-32768" as updated guidelines suggest.
---
Changes in v5:
- Add Krzysztof Kozlowski's Acked-by on patch 1/3 (given during v3 review, was accidentally dropped in v4).

Alberto Robazza (3):
dt-bindings: vendor-prefixes: add Orbbec
dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible
arm64: dts: amlogic: add support for Orbbec Zora P1

 .../devicetree/bindings/arm/amlogic.yaml      |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../boot/dts/amlogic/meson-g12b-zora-p1.dts   | 105 ++++++++++++++++++
 4 files changed, 109 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts
Signature · 1 line
2.55.0