Skip to content

t: add and use a commit_body test helper

Shlok Kulshreshtha git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2test-lib-functions: add commit_body helpert/README t/test-lib-functions.sh+19 -00 replies
2/2t: use commit_body to extract commit message bodiest/t3404-rebase-interactive.sh t/t3405-rebase-malformed.sh t/t3408-rebase-multi-line.sh +10 more+72 -1233 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] t: add and use a commit_body test helper

Junio pointed out that t7509-commit-authorship.sh defines its own local message_body() helper that wraps the same "git cat-file commit | sed" idiom commit_body was introduced to replace, which the first version of this series missed. Rechecking the whole idiom by its sed address, rather than by grepping for "cat-file", turned up one more inline occurrence with a spacing/escaping variant in t3404-rebase-interactive.sh that also didn't match the four spellings enumerated in v1.

Changes since v1:

2/2: fold in t7509's message_body helper (drop it, convert its six
call sites to commit_body) and the missed inline site in t3404. Site count is now 61 in 12 files, plus the removed helper.

Shlok Kulshreshtha (2):
test-lib-functions: add commit_body helper
t: use commit_body to extract commit message bodies

 t/README                                  | 11 ++++
 t/t3404-rebase-interactive.sh             |  2 +-
 t/t3405-rebase-malformed.sh               |  8 +--
 t/t3408-rebase-multi-line.sh              |  4 +-
 t/t3434-rebase-i18n.sh                    |  3 +-
 t/t3900-i18n-commit.sh                    |  4 +-
 t/t4150-am.sh                             |  8 +--
 t/t7500-commit-template-squash-signoff.sh |  4 +-
 t/t7501-commit-basic-functionality.sh     | 21 +++----
 t/t7502-commit-porcelain.sh               | 77 ++++++++---------------
 t/t7509-commit-authorship.sh              | 23 +++----
 t/t7600-merge.sh                          | 14 ++---
 t/t7604-merge-custom-message.sh           | 18 ++----
 t/t7614-merge-signoff.sh                  |  9 +--
 t/test-lib-functions.sh                   |  8 +++
 15 files changed, 91 insertions(+), 123 deletions(-)
Signature · 1 line
2.52.0