more hardening fixes for s390
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | hw/char/sclpconsole-lm: avoid guest triggerable asserthw/ | +2 | 1 reply | |
| 2/5 | s390x/ipl: validate num_comp against iplb length before iteratinghw/ | +6 | 1 reply | |
| 3/5 | pc-bios/s390-ccw: fix out-of-bounds read in iso_get_file_size()pc-bios/ | +1 | 1 reply | |
| 4/5 | pc-bios/s390-ccw: bounds-check zipl menu entry index before array writepc-bios/ | +11 | 1 reply | |
| 5/5 | pc-bios/s390-ccw: bound zipl menu strlen and replace VLA in zipl_print_entrypc-bios/ pc-bios/ pc-bios/ +1 more | +32 | 4 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Christian Borntraeger | Eric Farman | Matthew Rosato |
|---|---|---|---|
| Series | R-b | ||
| 1/5 | R-b | ||
| 2/5 | R-b | R-b | |
| 3/5 | R-b | R-b | |
| 4/5 | R-b | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/5] more hardening fixes for s390
Cornelia, Eric, Matt,
here are 5 more fixes for hardening QEMU against invalid input. Nothing is strictly a security issues as defined in the policy. For example
https://qemu-project.gitlab.io/qemu/system/security.html says assert /
abort: If triggering the code path requires kernel privileges (or root account access) in the guest, asserts/aborts in QEMU are a self inflicted denial of service. These will not be treated as security flaws, at most hardening bugs.
And if anyone can provide invalid boot loader content it can provide anything to boot if secure boot is not available.
We should fix those anyway, probably even for 11.1
Conny, I did not rebuild the s390-ccw, I assume you will do that?
Christian Borntraeger (1):
hw/char/sclpconsole-lm: avoid guest triggerable assert
Joshua Daley (4):
s390x/ipl: validate num_comp against iplb length before iterating pc-bios/s390-ccw: fix out-of-bounds read in iso_get_file_size() pc-bios/s390-ccw: bounds-check zipl menu entry index before array
write
pc-bios/s390-ccw: bound zipl menu strlen and replace VLA in
zipl_print_entry
hw/char/sclpconsole-lm.c | 3 ++- hw/s390x/ipl.h | 6 ++++++ pc-bios/s390-ccw/bootmap.c | 6 ++++-- pc-bios/s390-ccw/helper.h | 10 ++++++++++ pc-bios/s390-ccw/menu.c | 36 +++++++++++++++++++++++++++++------- pc-bios/s390-ccw/s390-ccw.h | 2 +- 6 files changed, 52 insertions(+), 11 deletions(-)
Signature · 1 line
2.53.0